a4506cd3f2
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
45 lines
1.5 KiB
C++
45 lines
1.5 KiB
C++
// Copyright 2011 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// CPU specific code for ia32 independent of OS goes here.
|
|
|
|
#ifdef __GNUC__
|
|
#include "src/third_party/valgrind/valgrind.h"
|
|
#endif
|
|
|
|
#include "src/v8.h"
|
|
|
|
#if V8_TARGET_ARCH_X87
|
|
|
|
#include "src/assembler.h"
|
|
#include "src/macro-assembler.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
void CpuFeatures::FlushICache(void* start, size_t size) {
|
|
// No need to flush the instruction cache on Intel. On Intel instruction
|
|
// cache flushing is only necessary when multiple cores running the same
|
|
// code simultaneously. V8 (and JavaScript) is single threaded and when code
|
|
// is patched on an intel CPU the core performing the patching will have its
|
|
// own instruction cache updated automatically.
|
|
|
|
// If flushing of the instruction cache becomes necessary Windows has the
|
|
// API function FlushInstructionCache.
|
|
|
|
// By default, valgrind only checks the stack for writes that might need to
|
|
// invalidate already cached translated code. This leads to random
|
|
// instability when code patches or moves are sometimes unnoticed. One
|
|
// solution is to run valgrind with --smc-check=all, but this comes at a big
|
|
// performance cost. We can notify valgrind to invalidate its cache.
|
|
#ifdef VALGRIND_DISCARD_TRANSLATIONS
|
|
unsigned res = VALGRIND_DISCARD_TRANSLATIONS(start, size);
|
|
USE(res);
|
|
#endif
|
|
}
|
|
|
|
} } // namespace v8::internal
|
|
|
|
#endif // V8_TARGET_ARCH_X87
|