026c972dd7
This CL explicitly encodes the 'other' reason for breaking for: * regular breakpoints * triggered pause events. The reason for explicitly encoding the reason is that we may otherwise not know why we pause when we handle it. This knowledge is needed in order to fully support instrumentation breakpoints, e.g. if we do not know that we paused on a triggered pause, and this happens to overlap with an instrumentation, we would previously only report 'instrumentation' as a reason which would be wrong. Bug: chromium:1229541 Change-Id: I93c08f965a491f6d34f280157b182a78d5b3cf07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289638 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#77970}
9 lines
456 B
Plaintext
9 lines
456 B
Plaintext
Test that all 'other' reasons are explicitly encoded on a pause event if they overlap with another reason
|
|
|
|
Running test: testBreakpointPauseReason
|
|
Paused with reason: instrumentation and data: {"url":"foo.js","scriptId":"3"}.
|
|
Paused with reason: other and data: {}.
|
|
|
|
Running test: testTriggeredPausePauseReason
|
|
Paused with reason: ambiguous and data: {"reasons":[{"reason":"instrumentation","auxData":{"url":"foo.js","scriptId":"4"}},{"reason":"other"}]}.
|