6da8e1f993
This reverts commit 34625fdb5a.
Reason for revert: Test caused timeout, investigating.
Original change's description:
> [Builtins] Array.prototype.forEach perf regression on dictionaries.
>
> An unnecessary call to ToString() on the array index caused trips to
> the runtime. The fix also includes performance micro-benchmarks so
> we'll have a harder time regressing this case in future.
>
> Bug: v8:8112
> Change-Id: Iada5bd2e3c6d2246fb1225e7094f3d9c66ddafbd
> Reviewed-on: https://chromium-review.googlesource.com/1206355
> Commit-Queue: Michael Stanton <mvstanton@chromium.org>
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55653}
TBR=mvstanton@chromium.org,tebbi@chromium.org
Change-Id: I21de9b9b33edf03f2173f579c4ba0fc3dfd8ff88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:8112
Reviewed-on: https://chromium-review.googlesource.com/1209288
Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55681}
75 lines
2.0 KiB
JavaScript
75 lines
2.0 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
(() => {
|
|
|
|
function Naive() {
|
|
let index = -1;
|
|
const length = array == null ? 0 : array.length;
|
|
|
|
for (let index = 0; index < length; index++) {
|
|
const value = array[index];
|
|
if (func(value, index, array)) {
|
|
result = value;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
function NaiveSetup() {
|
|
// Prime Naive with polymorphic cases.
|
|
array = [1, 2, 3];
|
|
Naive();
|
|
Naive();
|
|
array = [3.4]; Naive();
|
|
array = new Array(10); array[0] = 'hello'; Naive();
|
|
SmiSetup();
|
|
delete array[1];
|
|
}
|
|
|
|
// Make sure we inline the callback, pick up all possible TurboFan
|
|
// optimizations.
|
|
function RunOptFast(multiple) {
|
|
// Use of variable multiple in the callback function forces
|
|
// context creation without escape analysis.
|
|
//
|
|
// Also, the arrow function requires inlining based on
|
|
// SharedFunctionInfo.
|
|
result = array.forEach((v, i, a) => v === `value ${multiple}`);
|
|
}
|
|
|
|
// Don't optimize because I want to optimize RunOptFast with a parameter
|
|
// to be used in the callback.
|
|
%NeverOptimizeFunction(OptFast);
|
|
function OptFast() { RunOptFast(max_index); }
|
|
|
|
function side_effect(a) { return a; }
|
|
%NeverOptimizeFunction(side_effect);
|
|
function OptUnreliable() {
|
|
result = array.forEach(func, side_effect(array));
|
|
}
|
|
|
|
DefineHigherOrderTests([
|
|
['NaiveForEachReplacement', Naive, NaiveSetup, v => v === max_index],
|
|
[
|
|
'DoubleForEach', newClosure('forEach'), DoubleSetup,
|
|
v => v === max_index + 0.5
|
|
],
|
|
['SmiForEach', newClosure('forEach'), SmiSetup, v => v === max_index],
|
|
[
|
|
'FastForEach', newClosure('forEach'), FastSetup,
|
|
v => v === `value ${max_index}`
|
|
],
|
|
[
|
|
'GenericForEach', newClosure('forEach', true), ObjectSetup,
|
|
v => v === max_index
|
|
],
|
|
['OptFastForEach', OptFast, FastSetup, undefined],
|
|
[
|
|
'OptUnreliableForEach', OptUnreliable, FastSetup,
|
|
v => v === `value ${max_index}`
|
|
]
|
|
]);
|
|
|
|
})();
|