11de0762dc
Avoid most of the {is_inline()} checks by having a {data_begin_} pointer
which either points at the inline storage or at the zone-allocated
memory.
This replaces a dynamic branch by a memory indirection, which is
beneficial for big (non-inline) BitVectors. For small BitVectors we will
have to see what the bots say; the hypothesis is that a memory load is
still faster than a dynamic branch.
Apart from better performance, this change allows for simpler code in
many places, including the iterator implementation.
R=jkummerow@chromium.org
Bug: v8:13063
Change-Id: I1e28279d1a438598e0b8403a6a4078c2cd2a4c48
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776685
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81902}
166 lines
3.5 KiB
C++
166 lines
3.5 KiB
C++
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/utils/bit-vector.h"
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "src/init/v8.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
using BitVectorTest = TestWithZone;
|
|
|
|
TEST_F(BitVectorTest, SmallBitVector) {
|
|
BitVector v(15, zone());
|
|
v.Add(1);
|
|
EXPECT_TRUE(v.Contains(1));
|
|
v.Remove(0);
|
|
EXPECT_TRUE(!v.Contains(0));
|
|
v.Add(0);
|
|
v.Add(1);
|
|
BitVector w(15, zone());
|
|
w.Add(1);
|
|
v.Intersect(w);
|
|
EXPECT_TRUE(!v.Contains(0));
|
|
EXPECT_TRUE(v.Contains(1));
|
|
}
|
|
|
|
TEST_F(BitVectorTest, SmallBitVectorIterator) {
|
|
BitVector v(64, zone());
|
|
v.Add(27);
|
|
v.Add(30);
|
|
v.Add(31);
|
|
v.Add(33);
|
|
BitVector::Iterator iter = v.begin();
|
|
BitVector::Iterator end = v.end();
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(27, *iter);
|
|
++iter;
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(30, *iter);
|
|
++iter;
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(31, *iter);
|
|
++iter;
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(33, *iter);
|
|
++iter;
|
|
EXPECT_TRUE(!(iter != end));
|
|
}
|
|
|
|
TEST_F(BitVectorTest, Union) {
|
|
BitVector v(15, zone());
|
|
v.Add(0);
|
|
BitVector w(15, zone());
|
|
w.Add(1);
|
|
v.Union(w);
|
|
EXPECT_TRUE(v.Contains(0));
|
|
EXPECT_TRUE(v.Contains(1));
|
|
}
|
|
|
|
TEST_F(BitVectorTest, CopyFrom) {
|
|
BitVector v(15, zone());
|
|
v.Add(0);
|
|
BitVector w(15, zone());
|
|
w.CopyFrom(v);
|
|
EXPECT_TRUE(w.Contains(0));
|
|
w.Add(1);
|
|
BitVector u(w, zone());
|
|
EXPECT_TRUE(u.Contains(0));
|
|
EXPECT_TRUE(u.Contains(1));
|
|
v.Union(w);
|
|
EXPECT_TRUE(v.Contains(0));
|
|
EXPECT_TRUE(v.Contains(1));
|
|
}
|
|
|
|
TEST_F(BitVectorTest, Union2) {
|
|
BitVector v(35, zone());
|
|
v.Add(0);
|
|
BitVector w(35, zone());
|
|
w.Add(33);
|
|
v.Union(w);
|
|
EXPECT_TRUE(v.Contains(0));
|
|
EXPECT_TRUE(v.Contains(33));
|
|
}
|
|
|
|
TEST_F(BitVectorTest, Intersect) {
|
|
BitVector v(35, zone());
|
|
v.Add(32);
|
|
v.Add(33);
|
|
BitVector w(35, zone());
|
|
w.Add(33);
|
|
v.Intersect(w);
|
|
EXPECT_TRUE(!v.Contains(32));
|
|
EXPECT_TRUE(v.Contains(33));
|
|
BitVector r(35, zone());
|
|
r.CopyFrom(v);
|
|
EXPECT_TRUE(!r.Contains(32));
|
|
EXPECT_TRUE(r.Contains(33));
|
|
}
|
|
|
|
TEST_F(BitVectorTest, Resize) {
|
|
BitVector v(35, zone());
|
|
v.Add(32);
|
|
v.Add(33);
|
|
EXPECT_TRUE(v.Contains(32));
|
|
EXPECT_TRUE(v.Contains(33));
|
|
EXPECT_TRUE(!v.Contains(22));
|
|
EXPECT_TRUE(!v.Contains(34));
|
|
v.Resize(50, zone());
|
|
EXPECT_TRUE(v.Contains(32));
|
|
EXPECT_TRUE(v.Contains(33));
|
|
EXPECT_TRUE(!v.Contains(22));
|
|
EXPECT_TRUE(!v.Contains(34));
|
|
EXPECT_TRUE(!v.Contains(43));
|
|
v.Resize(300, zone());
|
|
EXPECT_TRUE(v.Contains(32));
|
|
EXPECT_TRUE(v.Contains(33));
|
|
EXPECT_TRUE(!v.Contains(22));
|
|
EXPECT_TRUE(!v.Contains(34));
|
|
EXPECT_TRUE(!v.Contains(43));
|
|
EXPECT_TRUE(!v.Contains(243));
|
|
}
|
|
|
|
TEST_F(BitVectorTest, BigBitVectorIterator) {
|
|
// Big BitVector with big and small entries.
|
|
BitVector v(500, zone());
|
|
v.Add(27);
|
|
v.Add(300);
|
|
v.Add(499);
|
|
auto iter = v.begin();
|
|
auto end = v.end();
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(27, *iter);
|
|
++iter;
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(300, *iter);
|
|
++iter;
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(499, *iter);
|
|
++iter;
|
|
EXPECT_EQ(iter, end);
|
|
|
|
// Remove small entries, add another big one.
|
|
v.Resize(1000, zone());
|
|
v.Remove(27);
|
|
v.Remove(300);
|
|
v.Add(500);
|
|
iter = v.begin();
|
|
end = v.end();
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(499, *iter);
|
|
++iter;
|
|
EXPECT_NE(iter, end);
|
|
EXPECT_EQ(500, *iter);
|
|
++iter;
|
|
EXPECT_EQ(iter, end);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|