aa8a208a47
Reason for revert:
Speculative revert because of blocked roll: https://codereview.chromium.org/2596013002/
Original issue's description:
> [TypeFeedbackVector] Root literal arrays in function literals slots
>
> Literal arrays and feedback vectors for a function can be garbage
> collected if we don't have a rooted closure for the function, which
> happens often. It's expensive to come back from this (recreating
> boilerplates and gathering feedback again), and the cost is
> disproportionate if the function was inlined into optimized code.
>
> To guard against losing these arrays when we need them, we'll now
> create literal arrays when creating the feedback vector for the outer
> closure, and root them strongly in that vector.
>
> BUG=v8:5456
>
> Review-Url: https://codereview.chromium.org/2504153002
> Cr-Commit-Position: refs/heads/master@{#41893}
> Committed: 93df094081
TBR=bmeurer@chromium.org,mlippautz@chromium.org,mvstanton@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5456
Review-Url: https://codereview.chromium.org/2597163002
Cr-Commit-Position: refs/heads/master@{#41917}
122 lines
3.0 KiB
Plaintext
122 lines
3.0 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
const x = 10; function f1() {return x;}
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 19
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(1),
|
|
B(PushContext), R(1),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(CreateClosure), U8(0), U8(2),
|
|
B(Star), R(0),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 44 S> */ B(LdaSmi), U8(10),
|
|
/* 44 E> */ B(StaCurrentContextSlot), U8(4),
|
|
B(LdaUndefined),
|
|
/* 74 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
const x = 10; function f1() {return x;} return x;
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 20
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(1),
|
|
B(PushContext), R(1),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(CreateClosure), U8(0), U8(2),
|
|
B(Star), R(0),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 44 S> */ B(LdaSmi), U8(10),
|
|
/* 44 E> */ B(StaCurrentContextSlot), U8(4),
|
|
/* 74 S> */ B(LdaCurrentContextSlot), U8(4),
|
|
/* 84 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
const x = (x = 20); function f1() {return x;}
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 39
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(1),
|
|
B(PushContext), R(1),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(CreateClosure), U8(0), U8(2),
|
|
B(Star), R(0),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 47 S> */ B(LdaSmi), U8(20),
|
|
B(Star), R(2),
|
|
B(LdaCurrentContextSlot), U8(4),
|
|
B(JumpIfNotHole), U8(11),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(3),
|
|
/* 47 E> */ B(CallRuntime), U16(Runtime::kThrowReferenceError), R(3), U8(1),
|
|
B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), U8(0),
|
|
/* 47 E> */ B(StaCurrentContextSlot), U8(4),
|
|
B(LdaUndefined),
|
|
/* 80 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["x"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
const x = 10; x = 20; function f1() {return x;}
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 26
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(1),
|
|
B(PushContext), R(1),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(CreateClosure), U8(0), U8(2),
|
|
B(Star), R(0),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 44 S> */ B(LdaSmi), U8(10),
|
|
/* 44 E> */ B(StaCurrentContextSlot), U8(4),
|
|
/* 48 S> */ B(LdaSmi), U8(20),
|
|
/* 50 E> */ B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), U8(0),
|
|
B(LdaUndefined),
|
|
/* 82 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|