aa8a208a47
Reason for revert:
Speculative revert because of blocked roll: https://codereview.chromium.org/2596013002/
Original issue's description:
> [TypeFeedbackVector] Root literal arrays in function literals slots
>
> Literal arrays and feedback vectors for a function can be garbage
> collected if we don't have a rooted closure for the function, which
> happens often. It's expensive to come back from this (recreating
> boilerplates and gathering feedback again), and the cost is
> disproportionate if the function was inlined into optimized code.
>
> To guard against losing these arrays when we need them, we'll now
> create literal arrays when creating the feedback vector for the outer
> closure, and root them strongly in that vector.
>
> BUG=v8:5456
>
> Review-Url: https://codereview.chromium.org/2504153002
> Cr-Commit-Position: refs/heads/master@{#41893}
> Committed: 93df094081
TBR=bmeurer@chromium.org,mlippautz@chromium.org,mvstanton@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5456
Review-Url: https://codereview.chromium.org/2597163002
Cr-Commit-Position: refs/heads/master@{#41917}
105 lines
2.2 KiB
Plaintext
105 lines
2.2 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: f
|
|
|
|
---
|
|
snippet: "
|
|
function f(arg1) { return function() { arg1 = 2; }; }
|
|
f();
|
|
"
|
|
frame size: 1
|
|
parameter count: 2
|
|
bytecode array length: 13
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(1),
|
|
B(PushContext), R(0),
|
|
B(Ldar), R(arg0),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
/* 10 E> */ B(StackCheck),
|
|
/* 19 S> */ B(CreateClosure), U8(0), U8(2),
|
|
/* 52 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
function f(arg1) { var a = function() { arg1 = 2; }; return arg1; }
|
|
f();
|
|
"
|
|
frame size: 2
|
|
parameter count: 2
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(1),
|
|
B(PushContext), R(1),
|
|
B(Ldar), R(arg0),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
/* 10 E> */ B(StackCheck),
|
|
/* 27 S> */ B(CreateClosure), U8(0), U8(2),
|
|
B(Star), R(0),
|
|
/* 53 S> */ B(LdaCurrentContextSlot), U8(4),
|
|
/* 66 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
function f(a1, a2, a3, a4) { return function() { a1 = a3; }; }
|
|
f();
|
|
"
|
|
frame size: 1
|
|
parameter count: 5
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(2),
|
|
B(PushContext), R(0),
|
|
B(Ldar), R(arg0),
|
|
B(StaCurrentContextSlot), U8(5),
|
|
B(Ldar), R(arg2),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
/* 10 E> */ B(StackCheck),
|
|
/* 29 S> */ B(CreateClosure), U8(0), U8(2),
|
|
/* 61 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
function f() { var self = this; return function() { self = 2; }; }
|
|
f();
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 13
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(1),
|
|
B(PushContext), R(0),
|
|
/* 10 E> */ B(StackCheck),
|
|
/* 26 S> */ B(Ldar), R(this),
|
|
/* 26 E> */ B(StaCurrentContextSlot), U8(4),
|
|
/* 32 S> */ B(CreateClosure), U8(0), U8(2),
|
|
/* 65 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|