2b873b94e9
This CL adds functionality to read the source positions directly from the JS heap rather than from serialized data. In order to do this, we create a PersistentHandles container in the OptimizedCompilationInfo which gets passed onto the JSHeapBroker. This allows us to create the handles in the main thread and pass them safely to the background thread. In order to read safely from the background thread, we need a LocalHeap which blocks the GC from running and potentially moving the handles. This LocalHeap is created only when the JSHeapBroker has finalized serializing and destroyed when retiring it. Bug: v8:7790 Change-Id: I19f8b08d12e5be0a3df34d6af2043310c0c7b6fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277802 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68836}
149 lines
4.1 KiB
C++
149 lines
4.1 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "test/unittests/compiler/graph-unittest.h"
|
|
|
|
#include "src/compiler/js-heap-copy-reducer.h"
|
|
#include "src/compiler/node-properties.h"
|
|
#include "src/heap/factory.h"
|
|
#include "src/objects/objects-inl.h" // TODO(everyone): Make typer.h IWYU compliant.
|
|
#include "test/unittests/compiler/node-test-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
GraphTest::GraphTest(int num_parameters)
|
|
: canonical_(isolate()),
|
|
common_(zone()),
|
|
graph_(zone()),
|
|
broker_(isolate(), zone(), isolate()->NewPersistentHandles()),
|
|
source_positions_(&graph_),
|
|
node_origins_(&graph_) {
|
|
graph()->SetStart(graph()->NewNode(common()->Start(num_parameters)));
|
|
graph()->SetEnd(graph()->NewNode(common()->End(1), graph()->start()));
|
|
broker()->SetTargetNativeContextRef(isolate()->native_context());
|
|
}
|
|
|
|
GraphTest::~GraphTest() = default;
|
|
|
|
|
|
Node* GraphTest::Parameter(int32_t index) {
|
|
return graph()->NewNode(common()->Parameter(index), graph()->start());
|
|
}
|
|
|
|
Node* GraphTest::Parameter(Type type, int32_t index) {
|
|
Node* node = GraphTest::Parameter(index);
|
|
NodeProperties::SetType(node, type);
|
|
return node;
|
|
}
|
|
|
|
Node* GraphTest::Float32Constant(volatile float value) {
|
|
return graph()->NewNode(common()->Float32Constant(value));
|
|
}
|
|
|
|
|
|
Node* GraphTest::Float64Constant(volatile double value) {
|
|
return graph()->NewNode(common()->Float64Constant(value));
|
|
}
|
|
|
|
|
|
Node* GraphTest::Int32Constant(int32_t value) {
|
|
return graph()->NewNode(common()->Int32Constant(value));
|
|
}
|
|
|
|
|
|
Node* GraphTest::Int64Constant(int64_t value) {
|
|
return graph()->NewNode(common()->Int64Constant(value));
|
|
}
|
|
|
|
|
|
Node* GraphTest::NumberConstant(volatile double value) {
|
|
return graph()->NewNode(common()->NumberConstant(value));
|
|
}
|
|
|
|
|
|
Node* GraphTest::HeapConstant(const Handle<HeapObject>& value) {
|
|
Node* node = graph()->NewNode(common()->HeapConstant(value));
|
|
Type type = Type::Constant(broker(), value, zone());
|
|
NodeProperties::SetType(node, type);
|
|
return node;
|
|
}
|
|
|
|
|
|
Node* GraphTest::FalseConstant() {
|
|
return HeapConstant(factory()->false_value());
|
|
}
|
|
|
|
|
|
Node* GraphTest::TrueConstant() {
|
|
return HeapConstant(factory()->true_value());
|
|
}
|
|
|
|
|
|
Node* GraphTest::UndefinedConstant() {
|
|
return HeapConstant(factory()->undefined_value());
|
|
}
|
|
|
|
|
|
Node* GraphTest::EmptyFrameState() {
|
|
Node* state_values =
|
|
graph()->NewNode(common()->StateValues(0, SparseInputMask::Dense()));
|
|
FrameStateFunctionInfo const* function_info =
|
|
common()->CreateFrameStateFunctionInfo(
|
|
FrameStateType::kInterpretedFunction, 0, 0,
|
|
Handle<SharedFunctionInfo>());
|
|
return graph()->NewNode(
|
|
common()->FrameState(BailoutId::None(), OutputFrameStateCombine::Ignore(),
|
|
function_info),
|
|
state_values, state_values, state_values, NumberConstant(0),
|
|
UndefinedConstant(), graph()->start());
|
|
}
|
|
|
|
|
|
Matcher<Node*> GraphTest::IsFalseConstant() {
|
|
return IsHeapConstant(factory()->false_value());
|
|
}
|
|
|
|
|
|
Matcher<Node*> GraphTest::IsTrueConstant() {
|
|
return IsHeapConstant(factory()->true_value());
|
|
}
|
|
|
|
Matcher<Node*> GraphTest::IsNullConstant() {
|
|
return IsHeapConstant(factory()->null_value());
|
|
}
|
|
|
|
Matcher<Node*> GraphTest::IsUndefinedConstant() {
|
|
return IsHeapConstant(factory()->undefined_value());
|
|
}
|
|
|
|
TypedGraphTest::TypedGraphTest(int num_parameters)
|
|
: GraphTest(num_parameters),
|
|
typer_(broker(), Typer::kNoFlags, graph(), tick_counter()) {}
|
|
|
|
TypedGraphTest::~TypedGraphTest() = default;
|
|
|
|
namespace graph_unittest {
|
|
|
|
const Operator kDummyOperator(0, Operator::kNoProperties, "Dummy", 0, 0, 0, 1,
|
|
0, 0);
|
|
|
|
|
|
TEST_F(GraphTest, NewNode) {
|
|
Node* n0 = graph()->NewNode(&kDummyOperator);
|
|
Node* n1 = graph()->NewNode(&kDummyOperator);
|
|
EXPECT_NE(n0, n1);
|
|
EXPECT_LT(0u, n0->id());
|
|
EXPECT_LT(0u, n1->id());
|
|
EXPECT_NE(n0->id(), n1->id());
|
|
EXPECT_EQ(&kDummyOperator, n0->op());
|
|
EXPECT_EQ(&kDummyOperator, n1->op());
|
|
}
|
|
|
|
} // namespace graph_unittest
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|