f774d8c56f
Once we enabled --turbo by default we need to turn all the implications off with --no-turbo as well. Chrome sets flags in V8 using SetFlagFromString, which enforces the implications each time it is called. Therefore, if --turbo is enabled by default, and an unrelated flag is set, the turbo implications are enabled but not later disabled if we set --no-turbo. To fix this, add negative implications as well. BUG=chromium:692409 Change-Id: Iadb0ca542f49ba65c7419cda8c7a03636a8d5ba9 Reviewed-on: https://chromium-review.googlesource.com/451320 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43655}
100 lines
2.8 KiB
JavaScript
100 lines
2.8 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --ignition --turbo
|
|
|
|
Debug = debug.Debug
|
|
|
|
var exception = null;
|
|
let a = 1;
|
|
var object = { property : 2,
|
|
get getter() { return 3; }
|
|
};
|
|
var string1 = { toString() { return "x"; } };
|
|
var string2 = { toString() { print("x"); return "x"; } };
|
|
var array = [4, 5];
|
|
var error = new Error();
|
|
|
|
function set_a() { a = 2; }
|
|
function get_a() { return a; }
|
|
var bound = get_a.bind(0);
|
|
|
|
var global_eval = eval;
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
function success(expectation, source) {
|
|
assertEquals(expectation,
|
|
exec_state.frame(0).evaluate(source, true).value());
|
|
}
|
|
function fail(source) {
|
|
assertThrows(() => exec_state.frame(0).evaluate(source, true),
|
|
EvalError);
|
|
}
|
|
// Simple test.
|
|
success(3, "1 + 2");
|
|
// Dymanic load.
|
|
success(array, "array");
|
|
// Context load.
|
|
success(1, "a");
|
|
// Global and named property load.
|
|
success(2, "object.property");
|
|
// Load via read-only getter.
|
|
success(3, "object.getter");
|
|
// Implicit call to read-only toString.
|
|
success("xy", "string1 + 'y'");
|
|
// Keyed property load.
|
|
success(5, "array[1]");
|
|
// Call to read-only function.
|
|
success(1, "get_a()");
|
|
success(1, "bound()");
|
|
success({}, "new get_a()");
|
|
// Call to read-only function within try-catch.
|
|
success(1, "try { get_a() } catch (e) {}");
|
|
// Call to C++ built-in.
|
|
success(Math.sin(2), "Math.sin(2)");
|
|
// Call to whitelisted get accessors.
|
|
success(3, "'abc'.length");
|
|
success(2, "array.length");
|
|
success(1, "'x'.length");
|
|
success(0, "set_a.length");
|
|
success("set_a", "set_a.name");
|
|
success(0, "bound.length");
|
|
success("bound get_a", "bound.name");
|
|
// Test that non-read-only code fails.
|
|
fail("exception = 1");
|
|
// Test that calling a non-read-only function fails.
|
|
fail("set_a()");
|
|
fail("new set_a()");
|
|
// Test that implicit call to a non-read-only function fails.
|
|
fail("string2 + 'y'");
|
|
// Test that try-catch does not catch the EvalError.
|
|
fail("try { set_a() } catch (e) {}");
|
|
// Test that call to set accessor fails.
|
|
fail("array.length = 4");
|
|
// Test that call to non-whitelisted get accessor fails.
|
|
fail("error.stack");
|
|
// Eval is not allowed.
|
|
fail("eval('Math.sin(1)')");
|
|
fail("eval('exception = 1')");
|
|
fail("global_eval('1')");
|
|
} catch (e) {
|
|
exception = e;
|
|
print(e, e.stack);
|
|
};
|
|
};
|
|
|
|
// Add the debug event listener.
|
|
Debug.setListener(listener);
|
|
|
|
function f() {
|
|
debugger;
|
|
};
|
|
|
|
f();
|
|
|
|
assertNull(exception);
|
|
assertEquals(1, a);
|