084471ce6b
This reverts commit d3e9aade0f.
Reason for revert: Speculative for:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/4449
Bisect points to this CL.
Original change's description:
> [Interpreter] Move BinaryOp Smi transformation into BytecodeGenerator.
>
> Perform the transformation to <BinaryOp>Smi for Binary ops which take Smi
> literals in the BytecodeGenerator. This enables us to perform the
> transformation for literals on either side for commutative operations, and
> Avoids having to do the check on every bytecode in the peephole optimizer.
>
> In the process, adds Smi bytecode variants for all binary operations, adding
> - MulSmi
> - DivSmi
> - ModSmi
> - BitwiseXorSmi
> - ShiftRightLogical
>
> BUG=v8:6194
>
> Change-Id: If1484252f5385c16957004b9cac8bfbb1f209219
> Reviewed-on: https://chromium-review.googlesource.com/466246
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#44477}
TBR=rmcilroy@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,mythria@chromium.org,ishell@chromium.org,v8-reviews@googlegroups.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6194
Change-Id: If57dbdbe40be77804bf437463b855d3167e2d473
Reviewed-on: https://chromium-review.googlesource.com/471308
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44488}
184 lines
4.2 KiB
Plaintext
184 lines
4.2 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
var x = 0;
|
|
label: {
|
|
x = x + 1;
|
|
break label;
|
|
x = x + 1;
|
|
}
|
|
return x;
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 16
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaZero),
|
|
B(Star), R(0),
|
|
/* 56 S> */ B(LdaSmi), I8(1),
|
|
/* 62 E> */ B(Add), R(0), U8(2),
|
|
B(Star), R(0),
|
|
/* 69 S> */ B(Jump), U8(2),
|
|
/* 97 S> */ B(Ldar), R(0),
|
|
/* 107 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var sum = 0;
|
|
outer: {
|
|
for (var x = 0; x < 10; ++x) {
|
|
for (var y = 0; y < 3; ++y) {
|
|
++sum;
|
|
if (x + y == 12) { break outer; }
|
|
}
|
|
}
|
|
}
|
|
return sum;
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 69
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 44 S> */ B(LdaZero),
|
|
B(Star), R(0),
|
|
/* 71 S> */ B(LdaZero),
|
|
B(Star), R(1),
|
|
/* 76 S> */ B(LdaSmi), I8(10),
|
|
/* 76 E> */ B(TestLessThan), R(1), U8(2),
|
|
B(JumpIfFalse), U8(54),
|
|
/* 58 E> */ B(StackCheck),
|
|
/* 106 S> */ B(LdaZero),
|
|
B(Star), R(2),
|
|
/* 111 S> */ B(LdaSmi), I8(3),
|
|
/* 111 E> */ B(TestLessThan), R(2), U8(4),
|
|
B(JumpIfFalse), U8(34),
|
|
/* 93 E> */ B(StackCheck),
|
|
/* 129 S> */ B(Ldar), R(0),
|
|
B(Inc), U8(6),
|
|
B(Star), R(0),
|
|
/* 142 S> */ B(Ldar), R(2),
|
|
/* 148 E> */ B(Add), R(1), U8(7),
|
|
B(Star), R(3),
|
|
B(LdaSmi), I8(12),
|
|
/* 152 E> */ B(TestEqual), R(3), U8(8),
|
|
B(JumpIfFalse), U8(4),
|
|
/* 161 S> */ B(Jump), U8(20),
|
|
/* 118 S> */ B(Ldar), R(2),
|
|
B(Inc), U8(5),
|
|
B(Star), R(2),
|
|
B(JumpLoop), U8(36), I8(1),
|
|
/* 84 S> */ B(Ldar), R(1),
|
|
B(Inc), U8(3),
|
|
B(Star), R(1),
|
|
B(JumpLoop), U8(56), I8(0),
|
|
/* 188 S> */ B(Ldar), R(0),
|
|
/* 200 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
outer: {
|
|
let y = 10;
|
|
function f() { return y; }
|
|
break outer;
|
|
}
|
|
"
|
|
frame size: 3
|
|
parameter count: 1
|
|
bytecode array length: 31
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(Ldar), R(closure),
|
|
B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(2),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(CreateClosure), U8(1), U8(2), U8(2),
|
|
B(Star), R(0),
|
|
/* 53 S> */ B(LdaSmi), I8(10),
|
|
/* 53 E> */ B(StaCurrentContextSlot), U8(4),
|
|
B(Mov), R(0), R(1),
|
|
B(Ldar), R(0),
|
|
/* 88 S> */ B(Jump), U8(2),
|
|
B(PopContext), R(2),
|
|
B(LdaUndefined),
|
|
/* 103 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
let x = 1;
|
|
outer: {
|
|
inner: {
|
|
let y = 2;
|
|
function f() { return x + y; }
|
|
if (y) break outer;
|
|
y = 3;
|
|
}
|
|
}
|
|
x = 4;
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 54
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(1),
|
|
B(PushContext), R(2),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
/* 42 E> */ B(StaCurrentContextSlot), U8(4),
|
|
B(Ldar), R(closure),
|
|
B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(3),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(CreateClosure), U8(1), U8(2), U8(2),
|
|
B(Star), R(0),
|
|
/* 76 S> */ B(LdaSmi), I8(2),
|
|
/* 76 E> */ B(StaCurrentContextSlot), U8(4),
|
|
B(Mov), R(0), R(1),
|
|
/* 118 S> */ B(LdaCurrentContextSlot), U8(4),
|
|
B(JumpIfToBooleanFalse), U8(6),
|
|
/* 125 S> */ B(PopContext), R(3),
|
|
B(Jump), U8(8),
|
|
/* 142 S> */ B(LdaSmi), I8(3),
|
|
/* 144 E> */ B(StaCurrentContextSlot), U8(4),
|
|
B(PopContext), R(3),
|
|
/* 155 S> */ B(LdaSmi), I8(4),
|
|
/* 157 E> */ B(StaCurrentContextSlot), U8(4),
|
|
B(LdaUndefined),
|
|
/* 162 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|