08a49bbe50
This reverts commit cf93071c91.
Reason for revert: Speculative revert because of Mac4 GC stress failure: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20GC%20Stress/16697/overview
Original change's description:
> [interpreter] Short Star bytecode
>
> Design doc:
> https://docs.google.com/document/d/1g_NExMT78II_KnIYNa9MvyPYIj23qAiFUEsyemY5KRk/edit
>
> This change adds 16 new interpreter opcodes, kStar0 through kStar15, so
> that we can use a single byte to represent the common operation of
> storing to a low-numbered register. This generally reduces the quantity
> of bytecode generated on web sites by 8-9%.
>
> In order to not degrade speed, a couple of other changes are required:
>
> The existing lookahead logic to check for Star after certain other
> bytecode handlers is updated to check for these new short Star codes
> instead. Furthermore, that lookahead logic is updated to contain its own
> copy of the dispatch jump rather than merging control flow with the
> lookahead-failed case, to improve branch prediction.
>
> A bunch of constants use bytecode size in bytes as a proxy for the size
> or complexity of a function, and are adjusted downward proportionally to
> the decrease in generated bytecode size.
>
> Other small drive-by fix: update generate-bytecode-expectations to emit
> \n instead of \r\n on Windows.
>
> Change-Id: I6307c2b0f5794a3a1088bb0fb94f6e1615441ed5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2641180
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#72773}
TBR=rmcilroy@chromium.org,mythria@chromium.org,seth.brenith@microsoft.com
Change-Id: I0162b9400861b90bacef27cca9aebc8ab9d74c10
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2697350
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72777}
188 lines
5.4 KiB
Plaintext
188 lines
5.4 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A {
|
|
#a() { return 1; }
|
|
}
|
|
}
|
|
"
|
|
frame size: 7
|
|
parameter count: 1
|
|
bytecode array length: 51
|
|
bytecodes: [
|
|
/* 30 E> */ B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(1),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(3),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(3), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(CreateClosure), U8(3), U8(0), U8(2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
B(LdaTheHole),
|
|
B(Star), R(6),
|
|
B(CreateClosure), U8(4), U8(1), U8(2),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(4),
|
|
B(Mov), R(2), R(5),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(3),
|
|
B(Star), R(4),
|
|
B(PopContext), R(1),
|
|
B(Mov), R(5), R(0),
|
|
B(LdaUndefined),
|
|
/* 77 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["A"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class D {
|
|
#d() { return 1; }
|
|
}
|
|
class E extends D {
|
|
#e() { return 2; }
|
|
}
|
|
}
|
|
"
|
|
frame size: 8
|
|
parameter count: 1
|
|
bytecode array length: 100
|
|
bytecodes: [
|
|
/* 30 E> */ B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(2),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(4),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(CreateClosure), U8(3), U8(0), U8(2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
B(LdaTheHole),
|
|
B(Star), R(7),
|
|
B(CreateClosure), U8(4), U8(1), U8(2),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(5),
|
|
B(Mov), R(3), R(6),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(3),
|
|
B(Star), R(5),
|
|
B(PopContext), R(2),
|
|
B(Mov), R(6), R(0),
|
|
/* 38 E> */ B(CreateBlockContext), U8(5),
|
|
B(PushContext), R(2),
|
|
B(LdaConstant), U8(7),
|
|
B(Star), R(4),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(CreateClosure), U8(8), U8(2), U8(2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 93 E> */ B(CreateClosure), U8(9), U8(3), U8(2),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(6),
|
|
B(Star), R(5),
|
|
B(Mov), R(3), R(6),
|
|
B(Mov), R(0), R(7),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(3),
|
|
B(Star), R(5),
|
|
B(PopContext), R(2),
|
|
B(Mov), R(6), R(1),
|
|
B(LdaUndefined),
|
|
/* 126 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["D"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["E"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
{
|
|
class A { foo() {} }
|
|
class C extends A {
|
|
#m() { return super.foo; }
|
|
}
|
|
}
|
|
"
|
|
frame size: 8
|
|
parameter count: 1
|
|
bytecode array length: 94
|
|
bytecodes: [
|
|
/* 30 E> */ B(CreateBlockContext), U8(0),
|
|
B(PushContext), R(2),
|
|
B(LdaTheHole),
|
|
B(Star), R(6),
|
|
B(CreateClosure), U8(2), U8(0), U8(2),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(1),
|
|
B(Star), R(4),
|
|
B(CreateClosure), U8(3), U8(1), U8(2),
|
|
B(Star), R(7),
|
|
B(Mov), R(3), R(5),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(4), U8(4),
|
|
B(Star), R(4),
|
|
B(PopContext), R(2),
|
|
B(Mov), R(5), R(0),
|
|
/* 38 E> */ B(CreateBlockContext), U8(4),
|
|
B(PushContext), R(2),
|
|
B(LdaConstant), U8(6),
|
|
B(Star), R(4),
|
|
B(CallRuntime), U16(Runtime::kCreatePrivateBrandSymbol), R(4), U8(1),
|
|
B(StaCurrentContextSlot), U8(3),
|
|
B(CreateClosure), U8(7), U8(2), U8(2),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 77 E> */ B(CreateClosure), U8(8), U8(3), U8(2),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(5),
|
|
B(Star), R(5),
|
|
B(Mov), R(3), R(6),
|
|
B(Mov), R(0), R(7),
|
|
B(CallRuntime), U16(Runtime::kDefineClass), R(5), U8(3),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(Star), R(5),
|
|
B(Ldar), R(6),
|
|
B(StaCurrentContextSlot), U8(5),
|
|
B(PopContext), R(2),
|
|
B(Star), R(1),
|
|
B(LdaUndefined),
|
|
/* 118 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SCOPE_INFO_TYPE,
|
|
FIXED_ARRAY_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["C"],
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|