980739a29c
This improves the generated code for HSeqStringSetChar across all platforms, taking advantage of constant operands whenever possible. It also drops the unused DefineSameAsFirst constraint for the register allocator on x64 and ia32, where it caused unnecessary spills when the string operand was live across the HSeqStringSetChar instruction. A new GVN flag StringChars is introduced to express dependencies between HSeqStringSetChar, HStringCharCodeAt and the upcoming HSeqStringGetChar (the GVNFlags type is now 64bit in size). Also improves the test case. TEST=mjsunit/string-natives R=mstarzinger@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/57383004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17521 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
81 lines
3.0 KiB
JavaScript
81 lines
3.0 KiB
JavaScript
// Copyright 2012 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --expose-gc --allow-natives-syntax
|
|
|
|
function test() {
|
|
var s1 = %NewString(26, true);
|
|
for (i = 0; i < 26; i++) %_OneByteSeqStringSetChar(s1, i, 65);
|
|
assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAA", s1);
|
|
%_OneByteSeqStringSetChar(s1, 25, 66);
|
|
assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAB", s1);
|
|
for (i = 0; i < 26; i++) %_OneByteSeqStringSetChar(s1, i, i+65);
|
|
assertEquals("ABCDEFGHIJKLMNOPQRSTUVWXYZ", s1);
|
|
s1 = %TruncateString(s1, 13);
|
|
assertEquals("ABCDEFGHIJKLM", s1);
|
|
|
|
var s2 = %NewString(26, false);
|
|
for (i = 0; i < 26; i++) %_TwoByteSeqStringSetChar(s2, i, 65);
|
|
assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAA", s2);
|
|
%_TwoByteSeqStringSetChar(s2, 25, 66);
|
|
assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAB", s2);
|
|
for (i = 0; i < 26; i++) %_TwoByteSeqStringSetChar(s2, i, i+65);
|
|
assertEquals("ABCDEFGHIJKLMNOPQRSTUVWXYZ", s2);
|
|
s2 = %TruncateString(s2, 13);
|
|
assertEquals("ABCDEFGHIJKLM", s2);
|
|
|
|
var s3 = %NewString(26, false);
|
|
for (i = 0; i < 26; i++) %_TwoByteSeqStringSetChar(s3, i, i+1000);
|
|
for (i = 0; i < 26; i++) assertEquals(s3[i], String.fromCharCode(i+1000));
|
|
|
|
var a = [];
|
|
for (var i = 0; i < 1000; i++) {
|
|
var s = %NewString(10000, i % 2 == 1);
|
|
a.push(s);
|
|
}
|
|
|
|
gc();
|
|
|
|
for (var i = 0; i < 1000; i++) {
|
|
assertEquals(10000, a[i].length);
|
|
a[i] = %TruncateString(a[i], 5000);
|
|
}
|
|
|
|
gc();
|
|
|
|
for (var i = 0; i < 1000; i++) {
|
|
assertEquals(5000, a[i].length);
|
|
}
|
|
}
|
|
|
|
|
|
test();
|
|
test();
|
|
%OptimizeFunctionOnNextCall(test);
|
|
test();
|
|
|