09ef5458c0
Construction of JSFunction objects is complex, mostly due to the existence of multiple functions kinds (JS, wasm, builtin, test, ...) that are all created slightly differently. For example, JS functions may come with an existing FeedbackCell (and FeedbackVector), while builtins and wasm functions always use the many_closures_cell (without a vector). Prior to this CL, construction logic was scattered over a family of 7 functions, without a clearly defined chokepoint for header initialization. This was hard to understand, hard to modify, and needlessly inefficient (by setting some fields twice). This CL fixes all that by introducing JSFunctionBuilder. The BuildRaw method is the chokepoint for allocation and initialization, and Build performs common pre- and post-work. Future work: - Remove now-deprecated functions. - Untangle SFI/Map/JSFunction construction and remove Factory::NewFunction and NewFunctionArgs. Bug: v8:8888 Change-Id: I709a2a44ee02e10593a4c9afe43d4d2c6d6351c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527098 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71084} |
||
|---|---|---|
| build_overrides | ||
| custom_deps | ||
| docs | ||
| gni | ||
| include | ||
| infra | ||
| samples | ||
| src | ||
| test | ||
| testing | ||
| third_party | ||
| tools | ||
| .clang-format | ||
| .clang-tidy | ||
| .editorconfig | ||
| .flake8 | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .gn | ||
| .vpython | ||
| .ycm_extra_conf.py | ||
| AUTHORS | ||
| BUILD.gn | ||
| CODE_OF_CONDUCT.md | ||
| codereview.settings | ||
| COMMON_OWNERS | ||
| DEPS | ||
| DIR_METADATA | ||
| ENG_REVIEW_OWNERS | ||
| INFRA_OWNERS | ||
| INTL_OWNERS | ||
| LICENSE | ||
| LICENSE.fdlibm | ||
| LICENSE.strongtalk | ||
| LICENSE.v8 | ||
| MIPS_OWNERS | ||
| OWNERS | ||
| PPC_OWNERS | ||
| PRESUBMIT.py | ||
| README.md | ||
| S390_OWNERS | ||
| WATCHLISTS | ||
V8 JavaScript Engine
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://v8.dev/docs
Getting the Code
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies.
To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote
configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Contributing
Please follow the instructions mentioned at v8.dev/docs/contribute.