07011cc4f0
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
and may causes nested Microtasks in a problematic way. E.g. that confuses
v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
respects the microtask suppressions.
As all existing tests don't call RunMicrotasks() in the suppressed situation
(like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
not affect to these tests.
Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
Reviewed-on: https://chromium-review.googlesource.com/c/1360095
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58068}
43 lines
1.2 KiB
JavaScript
43 lines
1.2 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
|
|
// Test debug events when we listen to all exceptions and
|
|
// there is a catch handler for the exception thrown in a Promise.
|
|
// We expect a normal Exception debug event to be triggered.
|
|
|
|
Debug = debug.Debug;
|
|
|
|
var expected_events = 1;
|
|
var log = [];
|
|
|
|
|
|
class P extends Promise {
|
|
constructor(...args) {
|
|
super(...args);
|
|
return new Proxy(this, {
|
|
get(target, property, receiver) {
|
|
if (property in target) {
|
|
return Reflect.get(target, property, receiver);
|
|
} else {
|
|
return (...args) =>
|
|
new Promise((resolve, reject) =>
|
|
target.then(v => resolve(v[property](...args)))
|
|
.catch(reject)
|
|
);
|
|
}
|
|
}
|
|
});
|
|
}
|
|
}
|
|
|
|
P.resolve({doStuff(){log.push(1)}}).doStuff()
|
|
|
|
function listener(event, exec_state, event_data, data) {}
|
|
|
|
Debug.setBreakOnUncaughtException();
|
|
Debug.setListener(listener);
|
|
|
|
%PerformMicrotaskCheckpoint();
|