abcc28ced0
This enables the v8_enable_embedded_builtins gn flag on non-ia32 builds and adds a new --stress-off-heap-code test mode to fyi bots. v8_enable_embedded_builtins=true changes accesses to constants and external references to go through the root list in builtins code. --stress-off-heap-code copies builtins code off-heap on isolate creation. A few drive-by-fixes: - ensure that we actually inspect the correct builtin during isolate-independence testing. - relax tests to decrease maintenance (now we only fail if a builtin should be isolate-independent but isn't). - switch to a different off-heap-trampoline register on arm due to conflicts with custom stub linkages. Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Bug: v8:6666 Change-Id: I09ad3c75cb4342f4c548ea780f275993730896c8 Reviewed-on: https://chromium-review.googlesource.com/934281 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51717} |
||
---|---|---|
.. | ||
client.v8.pyl | ||
OWNERS | ||
README.md | ||
tryserver.v8.pyl |
Src-side test specifications
Src-side test specifications enable developers to quickly add tests running on specific bots on V8's continuous infrastructure (CI) or tryserver. Features to be tested must live behind runtime flags, which are mapped to named testing variants specified here. Changes to src-side test specifications go through CQ like any other CL and require tests added for specific trybots to pass.
The test specifications are defined in a V8-side folder called infra/testing.
Every master has an optional file named <mastername>.pyl
. E.g.
tryserver.v8.pyl
.
The structure of each file is:
{
<buildername>: [
{
'name': <test-spec name>,
'variant': <variant name>,
'shards': <number of shards>,
},
...
],
...
}
The <buildername>
is a string name of the builder to execute the tests.
<test-spec name>
is a label defining a test specification matching the
infra-side.
The <variant name>
is a testing variant specified
here.
<number of shards>
is optional (default 1), but can be provided to increase
the swarming shards for long-running tests.
Example:
{
'v8_linux64_rel_ng_triggered': [
{'name': 'v8testing', 'variant': 'nooptimization', 'shards': 2},
],
}
Guidelines
Please keep trybots and continuous bots in sync. E.g. add the same configuration for the release and debug CI bots and the corresponding trybot (where applicable). E.g.
tryserver.v8:
v8_linux64_rel_ng_triggered
client.v8:
V8 Linux64
V8 Linux64 - debug
Please only add tests that are expected to pass, or skip failing tests via status file for the selected testing variants only. If you want to add FYI tests (i.e. not closing the tree and not blocking CQ) you can do so for the following set of bots:
tryserver.v8:
v8_linux64_fyi_rel_ng_triggered
client.v8:
V8 Linux64 - fyi
V8 Linux64 - debug - fyi