8a1bafaf1a
There was a data race in the access of the foreground_task_runner_map_. I protect each access to foreground_task_runner_map_ with a lock now. Original change's description: > [platform] Implement TaskRunners in the DefaultPlatform > > This CL implements the TaskRunners in the DefaultPlatform which has been > added recently to the platform API. In addition I changed how task > posting works on the DefaultPlatform. > > With this implementation the DefaultPlatform keeps one > DefaultForegroundTaskRunner per isolate, plus one > DefaultBackgroundTaskRunner. The DefaultPlatform owns these TaskRunners > with a shared_ptr, which is also shared with any caller of > GetForegroundTaskRunner or GetBackgroundTaskrunner. > > This CL moves the task management from the DefaultPlatform to the > TaskRunners. The DefaultForegroundTaskRunner owns and manages the the > task queue, the delayed task queue, and the idle task queue. The > DefaultBackgroundTaskRunner owns the WorkerThread pool and the > background task queue. > > In addition changed many Task* to std::unique_ptr<Task> to document task > ownership. > > R=rmcilroy@chromium.org > > Change-Id: Ib9a01f1f45e5b48844a37d801f884210ec3f6c27 > Reviewed-on: https://chromium-review.googlesource.com/753583 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49354} Change-Id: Iddccdb07bde1a799815ec6ed6af37082df4987c7 Reviewed-on: https://chromium-review.googlesource.com/770970 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49379}
55 lines
1.3 KiB
C++
55 lines
1.3 KiB
C++
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_LIBPLATFORM_TASK_QUEUE_H_
|
|
#define V8_LIBPLATFORM_TASK_QUEUE_H_
|
|
|
|
#include <queue>
|
|
|
|
#include "include/libplatform/libplatform-export.h"
|
|
#include "src/base/macros.h"
|
|
#include "src/base/platform/mutex.h"
|
|
#include "src/base/platform/semaphore.h"
|
|
#include "testing/gtest/include/gtest/gtest_prod.h" // nogncheck
|
|
|
|
namespace v8 {
|
|
|
|
class Task;
|
|
|
|
namespace platform {
|
|
|
|
class V8_PLATFORM_EXPORT TaskQueue {
|
|
public:
|
|
TaskQueue();
|
|
~TaskQueue();
|
|
|
|
// Appends a task to the queue. The queue takes ownership of |task|.
|
|
void Append(std::unique_ptr<Task> task);
|
|
|
|
// Returns the next task to process. Blocks if no task is available. Returns
|
|
// nullptr if the queue is terminated.
|
|
std::unique_ptr<Task> GetNext();
|
|
|
|
// Terminate the queue.
|
|
void Terminate();
|
|
|
|
private:
|
|
FRIEND_TEST(WorkerThreadTest, PostSingleTask);
|
|
|
|
void BlockUntilQueueEmptyForTesting();
|
|
|
|
base::Semaphore process_queue_semaphore_;
|
|
base::Mutex lock_;
|
|
std::queue<std::unique_ptr<Task>> task_queue_;
|
|
bool terminated_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(TaskQueue);
|
|
};
|
|
|
|
} // namespace platform
|
|
} // namespace v8
|
|
|
|
|
|
#endif // V8_LIBPLATFORM_TASK_QUEUE_H_
|