b141fedfed
Previously having a `Symbol.toStringTag` property holding a string
somewhere in the prototype chain would always take predence over trying
to determine a reasonable name from the "constructor" (in case of
subclassing). This would lead to confusing behavior when diagnosing
objects in DevTools, for example
```js
class A extends URLSearchParams {};
new A()
```
would show `URLSearchParam` as class name for the instance rather than
`A`.
With this CL, we change the lookup logic to explicitly check for
`Symbol.toStringTag` and "constructor" along each step of the prototype
chain (skipping the "constructor" for the leaf object) and pick the
first one that yields a string (that is the function debug name in case
of "constructor").
Fixed: chromium:980018
Change-Id: Ic920b4bae02f965bc383c711f8de89c0de55fcac
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3231078
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77453}
29 lines
882 B
JavaScript
29 lines
882 B
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start('Regression test for crbug.com/980018');
|
|
|
|
contextGroup.addInlineScript(`
|
|
class A extends Map {
|
|
}
|
|
|
|
class B extends Map {
|
|
constructor() {
|
|
super();
|
|
Object.defineProperty(this, Symbol.toStringTag, {value: 'ThisIsB'});
|
|
}
|
|
}
|
|
|
|
class C extends Map {
|
|
}
|
|
Object.defineProperty(C.prototype, Symbol.toStringTag, {value: 'ThisIsC'});`);
|
|
|
|
InspectorTest.runAsyncTestSuite([
|
|
async function testClassNames() {
|
|
await Protocol.Runtime.enable();
|
|
await Promise.all(['A', 'B', 'C'].map(klass => Protocol.Runtime.evaluate({expression: `new ${klass}();`}).then(({result}) => InspectorTest.logMessage(result))));
|
|
await Protocol.Runtime.disable();
|
|
}
|
|
]);
|