5ca49a22d6
REPL 'let' declared variables use VariableLocation::REPL_GLOBAL which was not handled by a switch in the bytecode generator. The default case ran into an UNREACHABLE. This CL fixes this by properly handling VariableLocation::REPL_GLOBAL for delete. Drive-by: Replaced the default case with an explicit case for VariableLocation::MODULE. Bug: chromium:1052721 Change-Id: I1330ff2f2c6f042a596a8298599a5d58769894f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060488 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#66301}
18 lines
616 B
JavaScript
18 lines
616 B
JavaScript
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start('Deleting REPL let does not crash V8 crbug.com/105271');
|
|
|
|
InspectorTest.runAsyncTestSuite([
|
|
async function deleteReplLetDeclaration() {
|
|
await Protocol.Runtime.enable();
|
|
const response = await Protocol.Runtime.evaluate({
|
|
expression: 'let x = 1; delete x;',
|
|
replMode: true,
|
|
});
|
|
InspectorTest.logMessage(response);
|
|
await Protocol.Runtime.disable();
|
|
}
|
|
]);
|