v8/test/cctest/heap
Dominik Inführ 11045926ca [test] Avoid disabling of RCS during runtime
Test was flaky since disabling of RCS at runtime is unsafe. Some code
(e.g. TRACE_GC) is run only in case RCS is enabled and such code paths
might also DCHECK that RCS is enabled.
A background thread (sweeping in this case) could've already
entered such a code path right before RCS is disabled. In this case the
guard at the entry still saw that RCS is enabled but subsequent DCHECKs
that ensure that RCS is enabled might fail.

We could fix this by completing the sweeper tasks before disabling RCS
but there might be other similar tasks which might be run at that point
in the future (e.g. memory unmapper).

Disabling the flag doesn't even seem to be needed for the initial
regression test, so it seems simpler to just not disable RCS anymore.

Bug: v8:12026
Change-Id: I878f7dd9a7a4abb6a501f7a7651a1240ef2082a6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3162043
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76845}
2021-09-15 13:49:08 +00:00
..
heap-tester.h Reland "Reland "[deoptimizer] Change deopt entries into builtins"" 2020-10-21 06:01:38 +00:00
heap-utils.cc [heap] Fix failed tests when enabling single generation 2021-04-21 07:33:51 +00:00
heap-utils.h [heap, infra] Remove --local-heaps and --concurrent-allocation flags 2021-02-01 11:01:26 +00:00
test-alloc.cc Reland "[include] Split out v8.h" 2021-08-24 13:08:55 +00:00
test-array-buffer-tracker.cc heap: ArrayBufferSweeper refactoring 2021-09-13 11:49:02 +00:00
test-compaction.cc [base] Move utils/vector.h to base/vector.h 2021-06-18 13:33:13 +00:00
test-concurrent-allocation.cc [heap] Fix failed tests when enabling single generation 2021-04-21 07:33:51 +00:00
test-concurrent-marking.cc [heap] Fix failed tests when enabling single generation 2021-04-21 07:33:51 +00:00
test-embedder-tracing.cc Reland "[include] Split out v8.h" 2021-08-24 13:08:55 +00:00
test-external-string-tracker.cc [heap] Make creation of NewSpace and NewLargeObjectSpace optional 2021-05-04 06:47:54 +00:00
test-heap.cc [test] Avoid disabling of RCS during runtime 2021-09-15 13:49:08 +00:00
test-incremental-marking.cc [test]: Fix platform lifetime in IncrementalMarkingUsingTasks. 2020-11-27 06:58:21 +00:00
test-invalidated-slots.cc [heap] Fix failed tests when enabling single generation 2021-04-21 07:33:51 +00:00
test-iterators.cc Reland "[include] Split out v8.h" 2021-08-24 13:08:55 +00:00
test-lab.cc Fix an instance of -Wunused-but-set-variable. 2021-07-26 20:52:03 +00:00
test-mark-compact.cc Reland "[include] Split out v8.h" 2021-08-24 13:08:55 +00:00
test-memory-measurement.cc [build] Reduce dependencies on deserializer.h 2021-06-29 13:21:57 +00:00
test-page-promotion.cc [test] Tests should only invoke NewSpace::Grow in safepoint 2020-09-24 16:14:10 +00:00
test-shared-heap.cc Reland "[include] Split out v8.h" 2021-08-24 13:08:55 +00:00
test-spaces.cc Reland "[include] Split out v8.h" 2021-08-24 13:08:55 +00:00
test-unmapper.cc [test]: Fix platform lifetime in EagerUnmappingInCollectAllAvailableGarbage. 2020-10-28 09:12:05 +00:00
test-weak-references.cc [ext-code-space] Migrate more code entries to CodeT 2021-06-18 08:42:47 +00:00
test-write-barrier.cc [heap] Fix failed tests when enabling single generation 2021-04-21 07:33:51 +00:00