31d2bb8670
Fix 1: Track Scope::needs_home_object and Scope::uses_super_property accurately. When "eval" is seen, figure out whether it can access "super" and if yes, set the corresponding home object as needed. Fix 2: The object literal scope shouldn't be entered for things inside spreads. Original: https://chromium-review.googlesource.com/c/v8/v8/+/2563275 Previous reland: https://chromium-review.googlesource.com/c/v8/v8/+/2637220 This saves memory (the home object doesn't need to be stored for each method, but only once per class) and hopefully makes the home object a constant in the optimized code. Detailed documentation of the changes: https://docs.google.com/document/d/1ZVXcoQdf9IdMsnRI9iyUjyq9NDoEyx9nA3XqMgwflMs/edit?usp=sharing Bug: v8:9237 Bug: chromium:1167918 Bug: chromium:1167981 Bug: chromium:1167988 Bug: chromium:1168055 Bug: chromium:1171195 Bug: chromium:1171600 Change-Id: I9686e0d90cd0c1128757eca440a88748897ee91e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655509 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#72422}
130 lines
2.3 KiB
JavaScript
130 lines
2.3 KiB
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
(function TestMethod() {
|
|
var object = {
|
|
__proto__: {
|
|
method(x) {
|
|
return 'proto' + x;
|
|
}
|
|
},
|
|
method(x) {
|
|
return super.method(x);
|
|
}
|
|
};
|
|
assertEquals('proto42', object.method(42));
|
|
})();
|
|
|
|
|
|
(function TestGetter() {
|
|
var object = {
|
|
__proto__: {
|
|
_x: 42,
|
|
get x() {
|
|
return 'proto' + this._x;
|
|
}
|
|
},
|
|
get x() {
|
|
return super.x;
|
|
}
|
|
};
|
|
assertEquals('proto42', object.x);
|
|
})();
|
|
|
|
|
|
(function TestSetter() {
|
|
var object = {
|
|
__proto__: {
|
|
_x: 0,
|
|
set x(v) {
|
|
return this._x = v;
|
|
}
|
|
},
|
|
set x(v) {
|
|
super.x = v;
|
|
}
|
|
};
|
|
assertEquals(1, object.x = 1);
|
|
assertEquals(1, object._x);
|
|
assertEquals(0, Object.getPrototypeOf(object)._x);
|
|
})();
|
|
|
|
|
|
(function TestOptimized() {
|
|
// Object literals without any accessors get optimized.
|
|
var object = {
|
|
method() {
|
|
return super.toString;
|
|
}
|
|
};
|
|
assertEquals(Object.prototype.toString, object.method());
|
|
})();
|
|
|
|
|
|
(function TestConciseGenerator() {
|
|
var o = {
|
|
__proto__: {
|
|
m() {
|
|
return 42;
|
|
}
|
|
},
|
|
*g() {
|
|
yield super.m();
|
|
},
|
|
};
|
|
|
|
assertEquals(42, o.g().next().value);
|
|
})();
|
|
|
|
|
|
(function TestSuperPropertyInEval() {
|
|
var y = 3;
|
|
var p = {
|
|
m() { return 1; },
|
|
get x() { return 2; }
|
|
};
|
|
var o = {
|
|
__proto__: p,
|
|
evalM() {
|
|
assertEquals(1, eval('super.m()'));
|
|
},
|
|
evalX() {
|
|
assertEquals(2, eval('super.x'));
|
|
},
|
|
globalEval1() {
|
|
assertThrows('super.x', SyntaxError);
|
|
assertThrows('super.m()', SyntaxError);
|
|
},
|
|
globalEval2() {
|
|
super.x;
|
|
assertThrows('super.x', SyntaxError);
|
|
assertThrows('super.m()', SyntaxError);
|
|
}
|
|
};
|
|
o.evalM();
|
|
o.evalX();
|
|
o.globalEval1();
|
|
o.globalEval2();
|
|
})();
|
|
|
|
|
|
(function TestSuperPropertyInArrow() {
|
|
var y = 3;
|
|
var p = {
|
|
m() { return 1; },
|
|
get x() { return 2; }
|
|
};
|
|
var o = {
|
|
__proto__: p,
|
|
arrow() {
|
|
assertSame(super.x, (() => super.x)());
|
|
assertSame(super.m(), (() => super.m())());
|
|
return (() => super.m())();
|
|
}
|
|
};
|
|
assertSame(1, o.arrow());
|
|
})();
|