v8/test/inspector/debugger/class-private-methods-static.js
Joyee Cheung f2fd4923f3 [class] error when accessing unused static private method at debug time
At the moment when the static private method is unused
in source code (either explicitly or through eval) but is accessed
at runtime through the debugger, and there are no other potential
references to the class variable in the source code otherwise,
the reference to the class variable is lost here since the class
variable would not be context-allocated, then we could not rebuild
a proper brand check for it.

For now, a ReferenceError would be thrown and the method is considered
"optimized away", similar to how unused ordinary methods in closures
work. Before this patch it would DCHECK when generating bytecode
for the debugger instead of throwing errors.

Bug: v8:9839, v8:8330
Change-Id: I5d63131a7bdba141d01a3e6459bc27d0f5953c1a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095637
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66734}
2020-03-16 18:07:03 +00:00

123 lines
3.8 KiB
JavaScript

// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-private-methods
let { session, contextGroup, Protocol } = InspectorTest.start(
"Test static private class methods"
);
const script = `
function run() {
class A {
static test() {
debugger;
}
static #field = 2;
#instanceMethod() { } // should not show up
get #instanceAccessor() { return this.#field; } // should not show up
set #instanceAccessor(val) { this.#field = val; } // should not show up
static set #writeOnly(val) { this.#field = val; }
static get #readOnly() { return this.#field; }
static get #accessor() { return this.#field; }
static set #accessor(val) { this.#field = val; }
static #inc() { return ++A.#accessor; }
};
A.test();
class B extends A {
static get #accessor() { return 'subclassAccessor'; }
static #subclassMethod() { return B.#accessor; }
static test() {
debugger;
}
}
B.test();
}`;
contextGroup.addScript(script);
InspectorTest.runAsyncTestSuite([
async function testScopesPaused() {
Protocol.Debugger.enable();
// Do not await here, instead oncePaused should be awaited.
Protocol.Runtime.evaluate({ expression: 'run()' });
InspectorTest.log('privateProperties on the base class');
let {
params: { callFrames }
} = await Protocol.Debugger.oncePaused(); // inside A.test()
let frame = callFrames[0];
let { result } = await Protocol.Runtime.getProperties({
objectId: frame.this.objectId
});
InspectorTest.logMessage(result.privateProperties);
InspectorTest.log('Evaluating A.#inc();');
({ result } = await Protocol.Debugger.evaluateOnCallFrame({
expression: 'A.#inc();',
callFrameId: callFrames[0].callFrameId
}));
InspectorTest.logObject(result);
InspectorTest.log('Evaluating this.#inc();');
({ result } = await Protocol.Debugger.evaluateOnCallFrame({
expression: 'this.#inc();',
callFrameId: callFrames[0].callFrameId
}));
InspectorTest.logObject(result);
InspectorTest.log('Evaluating ++this.#accessor;');
({ result } = await Protocol.Debugger.evaluateOnCallFrame({
expression: '++this.#accessor;',
callFrameId: callFrames[0].callFrameId
}));
InspectorTest.logObject(result);
InspectorTest.log('Evaluating this.#readOnly;');
({ result } = await Protocol.Debugger.evaluateOnCallFrame({
expression: 'this.#readOnly;',
callFrameId: callFrames[0].callFrameId
}));
InspectorTest.logObject(result);
InspectorTest.log('Evaluating this.#writeOnly = 0; this.#field;');
({ result } = await Protocol.Debugger.evaluateOnCallFrame({
expression: 'this.#writeOnly = 0; this.#field;',
callFrameId: callFrames[0].callFrameId
}));
InspectorTest.logObject(result);
Protocol.Debugger.resume();
({ params: { callFrames } } = await Protocol.Debugger.oncePaused()); // B.test();
frame = callFrames[0];
InspectorTest.log('privateProperties on the subclass');
({ result } = await Protocol.Runtime.getProperties({
objectId: frame.this.objectId
}));
InspectorTest.logMessage(result.privateProperties);
InspectorTest.log('Evaluating this.#inc(); from the base class');
({ result } = await Protocol.Debugger.evaluateOnCallFrame({
expression: 'this.#inc();',
callFrameId: callFrames[0].callFrameId
}));
InspectorTest.logMessage(result);
InspectorTest.log('Evaluating this.#subclassMethod();');
({ result } = await Protocol.Debugger.evaluateOnCallFrame({
expression: 'this.#subclassMethod();',
callFrameId: callFrames[0].callFrameId
}));
InspectorTest.logMessage(result);
Protocol.Debugger.resume();
Protocol.Debugger.disable();
}
]);