2069ab2202
Reason for revert: Test failures: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/8046 Original issue's description: > [compiler] Add relocatable pointer constants for wasm memory references. > > Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. > > R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org > > Committed: https://crrev.com/eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 > Cr-Commit-Position: refs/heads/master@{#35182} TBR=bradnelson@chromium.org,titzer@chromium.org,gdeepti@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1846083005 Cr-Commit-Position: refs/heads/master@{#35185}
84 lines
2.4 KiB
C++
84 lines
2.4 KiB
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "src/debug/debug.h"
|
|
#include "src/disasm.h"
|
|
#include "src/disassembler.h"
|
|
#include "src/ic/ic.h"
|
|
#include "src/macro-assembler.h"
|
|
#include "test/cctest/cctest.h"
|
|
#include "test/cctest/compiler/c-signature.h"
|
|
#include "test/cctest/compiler/call-tester.h"
|
|
|
|
using namespace v8::internal;
|
|
using namespace v8::internal::compiler;
|
|
|
|
#define __ assm.
|
|
|
|
static int32_t DummyStaticFunction(Object* result) { return 1; }
|
|
TEST(WasmRelocationX64movq64) {
|
|
CcTest::InitializeVM();
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
HandleScope scope(isolate);
|
|
v8::internal::byte buffer[4096];
|
|
Assembler assm(isolate, buffer, sizeof buffer);
|
|
DummyStaticFunction(NULL);
|
|
int64_t imm = 1234567;
|
|
|
|
__ movq(rax, imm, RelocInfo::WASM_MEMORY_REFERENCE);
|
|
__ nop();
|
|
__ ret(0);
|
|
|
|
CodeDesc desc;
|
|
assm.GetCode(&desc);
|
|
Handle<Code> code = isolate->factory()->NewCode(
|
|
desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
|
|
USE(code);
|
|
|
|
CSignature0<int64_t> csig;
|
|
CodeRunner<int64_t> runnable(isolate, code, &csig);
|
|
int64_t ret_value = runnable.Call();
|
|
CHECK_EQ(ret_value, imm);
|
|
|
|
#ifdef OBJECT_PRINT
|
|
OFStream os(stdout);
|
|
code->Print(os);
|
|
byte* begin = code->instruction_start();
|
|
byte* end = begin + code->instruction_size();
|
|
disasm::Disassembler::Disassemble(stdout, begin, end);
|
|
#endif
|
|
size_t offset = 1234;
|
|
|
|
// Relocating references by offset
|
|
int mode_mask = (1 << RelocInfo::WASM_MEMORY_REFERENCE);
|
|
for (RelocIterator it(*code, mode_mask); !it.done(); it.next()) {
|
|
RelocInfo::Mode mode = it.rinfo()->rmode();
|
|
if (RelocInfo::IsWasmMemoryReference(mode)) {
|
|
// Dummy values of size used here as the objective of the test is to
|
|
// verify that the immediate is patched correctly
|
|
it.rinfo()->update_wasm_memory_reference(
|
|
it.rinfo()->wasm_memory_reference(),
|
|
it.rinfo()->wasm_memory_reference() + offset, 1, 2,
|
|
SKIP_ICACHE_FLUSH);
|
|
}
|
|
}
|
|
|
|
// Check if immediate is updated correctly
|
|
ret_value = runnable.Call();
|
|
CHECK_EQ(ret_value, imm + offset);
|
|
|
|
#ifdef OBJECT_PRINT
|
|
code->Print(os);
|
|
begin = code->instruction_start();
|
|
end = begin + code->instruction_size();
|
|
disasm::Disassembler::Disassemble(stdout, begin, end);
|
|
#endif
|
|
}
|
|
|
|
#undef __
|