5145860836
When triggering a step out action, we check whether we already are at a return or suspend location. If not, we first flood all return positions with breakpoints, set the fast_forward_to_return_ flag and continue. With the new way of reporting instrumentation breakpoints, we now may get into the situation where we stopped on an instrumentation, but may still need to continue until we reach the return point for the step out. This CL fixes a bug in which we ran into a DCHECK that expected us to stop on a return location (since fast_forward_to_return_ is set to true), but we didn't. Drive-by: adapt other stepping tests to properly wait for all pauses Bug: chromium:1229541 Change-Id: Ie5fd358922f4cdaf1f8584bb0b35e87b0e221fb8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3480094 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#79226}
38 lines
1.9 KiB
Plaintext
38 lines
1.9 KiB
Plaintext
Test that all 'other' reasons are explicitly encoded on a pause event if they overlap with another reason
|
|
|
|
Running test: testBreakpointPauseReason
|
|
Paused with reason instrumentation, data {"scriptId":"3","url":"foo.js"} and scriptId: 3.
|
|
Paused with reason other, data {} and scriptId: 3.
|
|
|
|
Running test: testTriggeredPausePauseReason
|
|
Paused with reason instrumentation, data {"scriptId":"4","url":"foo.js"} and scriptId: 4.
|
|
Paused with reason other, data {} and scriptId: 4.
|
|
|
|
Running test: testSteppingPauseReason
|
|
Paused with reason instrumentation, data {"scriptId":"5","url":"foo.js"} and scriptId: 5.
|
|
Paused with reason other, data {} and scriptId: 5.
|
|
Paused with reason other, data {} and scriptId: 5.
|
|
Paused with reason instrumentation, data {"scriptId":"6","url":"bar.js"} and scriptId: 6.
|
|
Paused with reason other, data {} and scriptId: 6.
|
|
|
|
Running test: testOnlyReportOtherWithEmptyDataOnce
|
|
Paused with reason other, data {} and scriptId: 7.
|
|
|
|
Running test: testDebuggerStatementReason
|
|
Paused with reason instrumentation, data {"scriptId":"8","url":"foo.js"} and scriptId: 8.
|
|
Paused with reason other, data {} and scriptId: 8.
|
|
|
|
Running test: testAsyncSteppingPauseReason
|
|
Paused with reason instrumentation, data {"scriptId":"9","url":"foo.js"} and scriptId: 9.
|
|
Paused with reason other, data {} and scriptId: 9.
|
|
Paused with reason other, data {} and scriptId: 9.
|
|
Paused with reason instrumentation, data {"scriptId":"10","url":"bar.js"} and scriptId: 10.
|
|
Paused with reason other, data {} and scriptId: 10.
|
|
Paused with reason other, data {} and scriptId: 10.
|
|
|
|
Running test: testSteppingOutPauseReason
|
|
Paused with reason instrumentation, data {"scriptId":"11","url":"foo.js"} and scriptId: 11.
|
|
Paused with reason other, data {} and scriptId: 11.
|
|
Paused with reason instrumentation, data {"scriptId":"12","url":"bar.js"} and scriptId: 12.
|
|
Paused with reason other, data {} and scriptId: 11.
|