14faced4c0
On x64 the {kScratchRegister} cannot be held in a {LiftoffRegister},
since it is not a valid cache register. Also, the code unnecessarily
checked whether there is an unused cache register, but then didn't use
it. Simplify the logic to always use the scratch register, just
distinguish between 4-byte and 8-byte moves.
On ia32 we did not move 64-bit values correctly if we didn't have
unused registers and needed to move via the stack.
R=titzer@chromium.org
Bug: v8:6600, chromium:917588, chromium:917450
Change-Id: I0bbe946c6ac8fca62f85711ae47afdac9c02ae6b
Reviewed-on: https://chromium-review.googlesource.com/c/1391755
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58521}
27 lines
799 B
JavaScript
27 lines
799 B
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
load('test/mjsunit/wasm/wasm-constants.js');
|
|
load('test/mjsunit/wasm/wasm-module-builder.js');
|
|
|
|
const builder = new WasmModuleBuilder();
|
|
const sig = builder.addType(makeSig([], [kWasmF64]));
|
|
builder.addFunction(undefined, sig)
|
|
.addLocals({f32_count: 5}).addLocals({f64_count: 3})
|
|
.addBody([
|
|
kExprBlock, kWasmF64,
|
|
kExprF64Const, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xf0, 0x3f,
|
|
kExprF64Const, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
|
|
kExprI32Const, 0,
|
|
kExprIf, kWasmI32,
|
|
kExprI32Const, 0,
|
|
kExprElse,
|
|
kExprI32Const, 1,
|
|
kExprEnd,
|
|
kExprBrIf, 0,
|
|
kExprUnreachable,
|
|
kExprEnd
|
|
]);
|
|
builder.instantiate();
|