ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
123 lines
3.7 KiB
C++
123 lines
3.7 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8-object.h"
|
|
#include "src/api/api-inl.h"
|
|
#include "src/execution/isolate.h"
|
|
#include "src/heap/combined-heap.h"
|
|
#include "src/heap/heap.h"
|
|
#include "src/heap/read-only-heap.h"
|
|
#include "src/heap/read-only-spaces.h"
|
|
#include "src/objects/heap-object.h"
|
|
#include "src/objects/objects.h"
|
|
#include "src/roots/roots-inl.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace heap {
|
|
|
|
TEST(HeapObjectIteratorNullPastEnd) {
|
|
HeapObjectIterator iterator(CcTest::heap());
|
|
while (!iterator.Next().is_null()) {
|
|
}
|
|
for (int i = 0; i < 20; i++) {
|
|
CHECK(iterator.Next().is_null());
|
|
}
|
|
}
|
|
|
|
TEST(ReadOnlyHeapObjectIteratorNullPastEnd) {
|
|
ReadOnlyHeapObjectIterator iterator(CcTest::read_only_heap());
|
|
while (!iterator.Next().is_null()) {
|
|
}
|
|
for (int i = 0; i < 20; i++) {
|
|
CHECK(iterator.Next().is_null());
|
|
}
|
|
}
|
|
|
|
TEST(CombinedHeapObjectIteratorNullPastEnd) {
|
|
CombinedHeapObjectIterator iterator(CcTest::heap());
|
|
while (!iterator.Next().is_null()) {
|
|
}
|
|
for (int i = 0; i < 20; i++) {
|
|
CHECK(iterator.Next().is_null());
|
|
}
|
|
}
|
|
|
|
namespace {
|
|
// An arbitrary object guaranteed to live on the non-read-only heap.
|
|
Object CreateWritableObject() {
|
|
return *v8::Utils::OpenHandle(*v8::Object::New(CcTest::isolate()));
|
|
}
|
|
} // namespace
|
|
|
|
TEST(ReadOnlyHeapObjectIterator) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
const Object sample_object = CreateWritableObject();
|
|
ReadOnlyHeapObjectIterator iterator(CcTest::read_only_heap());
|
|
|
|
for (HeapObject obj = iterator.Next(); !obj.is_null();
|
|
obj = iterator.Next()) {
|
|
CHECK(ReadOnlyHeap::Contains(obj));
|
|
CHECK(!CcTest::heap()->Contains(obj));
|
|
CHECK_NE(sample_object, obj);
|
|
}
|
|
}
|
|
|
|
TEST(HeapObjectIterator) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
const Object sample_object = CreateWritableObject();
|
|
HeapObjectIterator iterator(CcTest::heap());
|
|
bool seen_sample_object = false;
|
|
|
|
for (HeapObject obj = iterator.Next(); !obj.is_null();
|
|
obj = iterator.Next()) {
|
|
CHECK_IMPLIES(!FLAG_enable_third_party_heap, !ReadOnlyHeap::Contains(obj));
|
|
CHECK(CcTest::heap()->Contains(obj));
|
|
if (sample_object == obj) seen_sample_object = true;
|
|
}
|
|
CHECK(seen_sample_object);
|
|
}
|
|
|
|
TEST(CombinedHeapObjectIterator) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
const Object sample_object = CreateWritableObject();
|
|
CombinedHeapObjectIterator iterator(CcTest::heap());
|
|
bool seen_sample_object = false;
|
|
|
|
for (HeapObject obj = iterator.Next(); !obj.is_null();
|
|
obj = iterator.Next()) {
|
|
CHECK(IsValidHeapObject(CcTest::heap(), obj));
|
|
if (sample_object == obj) seen_sample_object = true;
|
|
}
|
|
CHECK(seen_sample_object);
|
|
}
|
|
|
|
TEST(PagedSpaceIterator) {
|
|
Heap* const heap = CcTest::heap();
|
|
PagedSpaceIterator iterator(heap);
|
|
CHECK_EQ(iterator.Next(), reinterpret_cast<PagedSpace*>(heap->old_space()));
|
|
CHECK_EQ(iterator.Next(), reinterpret_cast<PagedSpace*>(heap->code_space()));
|
|
CHECK_EQ(iterator.Next(), reinterpret_cast<PagedSpace*>(heap->map_space()));
|
|
for (int i = 0; i < 20; i++) {
|
|
CHECK_NULL(iterator.Next());
|
|
}
|
|
}
|
|
|
|
TEST(SpaceIterator) {
|
|
auto* const read_only_space = CcTest::read_only_heap()->read_only_space();
|
|
for (SpaceIterator it(CcTest::heap()); it.HasNext();) {
|
|
// ReadOnlySpace is not actually a Space but is instead a BaseSpace, but
|
|
// ensure it's not been inserted incorrectly.
|
|
CHECK_NE(it.Next(), reinterpret_cast<BaseSpace*>(read_only_space));
|
|
}
|
|
}
|
|
|
|
} // namespace heap
|
|
} // namespace internal
|
|
} // namespace v8
|