7d32cf4ee7
This CL fixes the new {CodeReference} class to comply to the style
guide. It makes it a proper class, renames private fields to end in an
underscore and simplifies the union declaration.
R=ahaas@chromium.org
CC=herhut@chromium.org
Bug: v8:7570
Change-Id: I329bbc6fca1ba3c0cb34fb4e1179eb4fa9044e76
Reviewed-on: https://chromium-review.googlesource.com/1023414
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52722}
53 lines
1.2 KiB
C++
53 lines
1.2 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_CODE_REFERENCE_H_
|
|
#define V8_CODE_REFERENCE_H_
|
|
|
|
#include "src/handles.h"
|
|
#include "src/objects/code.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
class Code;
|
|
|
|
namespace wasm {
|
|
class WasmCode;
|
|
}
|
|
|
|
class CodeReference {
|
|
public:
|
|
CodeReference() : kind_(JS), js_code_() {}
|
|
explicit CodeReference(const wasm::WasmCode* wasm_code)
|
|
: kind_(WASM), wasm_code_(wasm_code) {}
|
|
explicit CodeReference(Handle<Code> js_code) : kind_(JS), js_code_(js_code) {}
|
|
|
|
Address constant_pool() const;
|
|
Address instruction_start() const;
|
|
Address instruction_end() const;
|
|
int instruction_size() const;
|
|
const byte* relocation_start() const;
|
|
const byte* relocation_end() const;
|
|
int relocation_size() const;
|
|
bool is_null() const {
|
|
return kind_ == JS ? js_code_.is_null() : wasm_code_ == nullptr;
|
|
}
|
|
|
|
private:
|
|
enum { JS, WASM } kind_;
|
|
union {
|
|
const wasm::WasmCode* wasm_code_;
|
|
Handle<Code> js_code_;
|
|
};
|
|
|
|
DISALLOW_NEW_AND_DELETE();
|
|
};
|
|
ASSERT_TRIVIALLY_COPYABLE(CodeReference);
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_CODE_REFERENCE_H_
|