a81e8d16f4
Previously the `Debugger.CallFrame`s in `Debugger.paused` events would report locations relative to the surrounding document in case of inline scripts with `//@ sourceURL` annotations (while `Runtime.CallFrame` was already fixed previously as part of crrev.com/c/3069289). With this CL the locations in `Debugger.CallFrame` are also appropriately adjusted. Drive-by-fix: Several inspector tests were (incorrectly) relying on this wrong treatment, and were also unnecessarily using //# sourceURL annotations. So part of this CL also addresses that problem and makes the tests more robust, using addInlineScript() helper. Fixed: chromium:1283049 Bug: chromium:1183990, chromium:578269 Change-Id: I6e3b215d951c3453c0a9cfc9bccf3dc3d5e92fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359619 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78450}
78 lines
2.2 KiB
JavaScript
78 lines
2.2 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start('Checks framework debugging with blackboxed ranges.');
|
|
|
|
contextGroup.addInlineScript(
|
|
`
|
|
function foo() {
|
|
return boo();
|
|
}
|
|
function boo() {
|
|
return 42;
|
|
}
|
|
function testFunction() {
|
|
foo();
|
|
}`,
|
|
'test.js');
|
|
|
|
session.setupScriptMap();
|
|
Protocol.Debugger.onPaused(message => {
|
|
session.logCallFrames(message.params.callFrames);
|
|
InspectorTest.log('');
|
|
Protocol.Debugger.stepInto();
|
|
});
|
|
var scriptId;
|
|
Protocol.Debugger.onScriptParsed(message => {
|
|
if (message.params.url === 'test.js') {
|
|
scriptId = message.params.scriptId;
|
|
}
|
|
});
|
|
|
|
Protocol.Debugger.enable()
|
|
.then(() => Protocol.Debugger.setBlackboxPatterns({patterns: ['expr\.js']}))
|
|
.then(() => InspectorTest.runTestSuite(testSuite));
|
|
|
|
var testSuite = [
|
|
function testEntireScript(next) {
|
|
testPositions([position(0, 0)]).then(next);
|
|
},
|
|
function testFooNotBlackboxed(next) {
|
|
testPositions([position(11, 0)]).then(next);
|
|
},
|
|
function testFooBlackboxed(next) {
|
|
testPositions([position(8, 0), position(10, 3)]).then(next);
|
|
},
|
|
function testBooPartiallyBlackboxed1(next) {
|
|
// first line is not blackboxed, second and third - blackboxed.
|
|
testPositions([position(12, 0)]).then(next);
|
|
},
|
|
function testBooPartiallyBlackboxed2(next) {
|
|
// first line is blackboxed, second - not, third - blackboxed.
|
|
testPositions([
|
|
position(11, 0), position(12, 0), position(13, 0)
|
|
]).then(next);
|
|
},
|
|
function testBooPartiallyBlackboxed3(next) {
|
|
// first line is blackboxed, second and third - not.
|
|
testPositions([
|
|
position(11, 0), position(12, 0), position(14, 0)
|
|
]).then(next);
|
|
}
|
|
];
|
|
|
|
function testPositions(positions) {
|
|
contextGroup.schedulePauseOnNextStatement('', '');
|
|
return Protocol.Debugger
|
|
.setBlackboxedRanges({scriptId: scriptId, positions: positions})
|
|
.then(InspectorTest.logMessage)
|
|
.then(
|
|
() => Protocol.Runtime.evaluate(
|
|
{expression: 'testFunction()//# sourceURL=expr.js'}));
|
|
}
|
|
|
|
function position(line, column) {
|
|
return {lineNumber: line, columnNumber: column};
|
|
}
|