1766012c99
This reverts commit 4482650907
.
Reason for revert: Broke V8 Linux64 TSAN https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/30932?
Original change's description:
> [wasm] Debug in Liftoff by default
>
> This flips the --debug-in-liftoff flag to be on by default.
> There are still some outstanding issues with that configuration, but not
> more than with the interpreter configuration. Thus flip now, such that
> we can fully focus on stabilizing that config.
>
> R=ecmziegler@chromium.org
>
> Bug: v8:10351
> Change-Id: I7681f40aa2516557ef3ab4efd9a2c1f88e3b4df7
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135727
> Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org>
> Commit-Queue: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#67018}
TBR=clemensb@chromium.org,ecmziegler@chromium.org
Change-Id: Idd0f7f6101e55785fba9afc3d9af09c0324d7c3b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:10351
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2137565
Reviewed-by: Zhi An Ng <zhin@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67019}
139 lines
5.0 KiB
JavaScript
139 lines
5.0 KiB
JavaScript
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --debug-in-liftoff
|
|
|
|
const {session, contextGroup, Protocol} =
|
|
InspectorTest.start('Tests stepping through wasm scripts.');
|
|
session.setupScriptMap();
|
|
|
|
utils.load('test/mjsunit/wasm/wasm-module-builder.js');
|
|
|
|
const builder = new WasmModuleBuilder();
|
|
|
|
const func_a =
|
|
builder.addFunction('wasm_A', kSig_v_v).addBody([kExprNop, kExprNop]);
|
|
|
|
// wasm_B calls wasm_A <param0> times.
|
|
const func_b = builder.addFunction('wasm_B', kSig_v_i)
|
|
.addBody([
|
|
// clang-format off
|
|
kExprLoop, kWasmStmt, // while
|
|
kExprLocalGet, 0, // -
|
|
kExprIf, kWasmStmt, // if <param0> != 0
|
|
kExprLocalGet, 0, // -
|
|
kExprI32Const, 1, // -
|
|
kExprI32Sub, // -
|
|
kExprLocalSet, 0, // decrease <param0>
|
|
kExprCallFunction, func_a.index, // -
|
|
kExprBr, 1, // continue
|
|
kExprEnd, // -
|
|
kExprEnd, // break
|
|
// clang-format on
|
|
])
|
|
.exportAs('main');
|
|
|
|
const module_bytes = builder.toArray();
|
|
|
|
function instantiate(bytes) {
|
|
let buffer = new ArrayBuffer(bytes.length);
|
|
let view = new Uint8Array(buffer);
|
|
for (let i = 0; i < bytes.length; ++i) {
|
|
view[i] = bytes[i] | 0;
|
|
}
|
|
|
|
let module = new WebAssembly.Module(buffer);
|
|
return new WebAssembly.Instance(module);
|
|
}
|
|
|
|
const getResult = msg => msg.result || InspectorTest.logMessage(msg);
|
|
|
|
const evalWithUrl = (code, url) =>
|
|
Protocol.Runtime
|
|
.evaluate({'expression': code + '\n//# sourceURL=v8://test/' + url})
|
|
.then(getResult);
|
|
|
|
function setBreakpoint(offset, scriptId, scriptUrl) {
|
|
InspectorTest.log(
|
|
'Setting breakpoint at offset ' + offset + ' on script ' + scriptUrl);
|
|
return Protocol.Debugger
|
|
.setBreakpoint(
|
|
{'location': {'scriptId': scriptId, 'lineNumber': 0, 'columnNumber': offset}})
|
|
.then(getResult);
|
|
}
|
|
|
|
// Only set breakpoints during the first loop iteration.
|
|
var first_iteration = true;
|
|
|
|
Protocol.Debugger.onPaused(async msg => {
|
|
let loc = msg.params.callFrames[0].location;
|
|
InspectorTest.log('Paused:');
|
|
await session.logSourceLocation(loc);
|
|
InspectorTest.log('Scope:');
|
|
for (var frame of msg.params.callFrames) {
|
|
var functionName = frame.functionName || '(anonymous)';
|
|
var lineNumber = frame.location.lineNumber;
|
|
var columnNumber = frame.location.columnNumber;
|
|
InspectorTest.log(`at ${functionName} (${lineNumber}:${columnNumber}):`);
|
|
if (!/^wasm/.test(frame.url)) {
|
|
InspectorTest.log(' -- skipped');
|
|
continue;
|
|
}
|
|
for (var scope of frame.scopeChain) {
|
|
InspectorTest.logObject(' - scope (' + scope.type + '):');
|
|
var properties = await Protocol.Runtime.getProperties(
|
|
{'objectId': scope.object.objectId});
|
|
for (var value of properties.result.result) {
|
|
var value_str = await getScopeValues(value.value);
|
|
InspectorTest.log(' ' + value.name + ': ' + value_str);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (first_iteration && loc.columnNumber == func_a.body_offset) {
|
|
// Check that setting breakpoints on active instances of A and B takes
|
|
// effect immediately.
|
|
setBreakpoint(func_a.body_offset + 1, loc.scriptId, frame.url);
|
|
// All of the following breakpoints are in reachable code, except offset 17.
|
|
for (offset of [18, 17, 11, 10, 8, 6, 2, 4]) {
|
|
setBreakpoint(func_b.body_offset + offset, loc.scriptId, frame.url);
|
|
}
|
|
first_iteration = false;
|
|
}
|
|
|
|
Protocol.Debugger.resume();
|
|
});
|
|
|
|
async function getScopeValues(value) {
|
|
if (value.type == 'object') {
|
|
let msg = await Protocol.Runtime.getProperties({objectId: value.objectId});
|
|
const printProperty = function(elem) {
|
|
return `"${elem.name}": ${elem.value.value} (${elem.value.type})`;
|
|
}
|
|
return msg.result.result.map(printProperty).join(', ');
|
|
}
|
|
return value.value + ' (' + value.type + ')';
|
|
}
|
|
|
|
(async function test() {
|
|
await Protocol.Debugger.enable();
|
|
InspectorTest.log('Instantiating.');
|
|
// Spawn asynchronously:
|
|
let instantiate_code = 'const instance = (' + instantiate + ')(' +
|
|
JSON.stringify(module_bytes) + ');';
|
|
evalWithUrl(instantiate_code, 'instantiate');
|
|
InspectorTest.log(
|
|
'Waiting for wasm script (ignoring first non-wasm script).');
|
|
// Ignore javascript and full module wasm script, get scripts for functions.
|
|
const [, {params: wasm_script}] = await Protocol.Debugger.onceScriptParsed(2);
|
|
// Set a breakpoint in function A at offset 0. When the debugger hits this
|
|
// breakpoint, new ones will be added.
|
|
await setBreakpoint(func_a.body_offset, wasm_script.scriptId, wasm_script.url);
|
|
InspectorTest.log('Calling main(4)');
|
|
await evalWithUrl('instance.exports.main(4)', 'runWasm');
|
|
InspectorTest.log('exports.main returned!');
|
|
InspectorTest.log('Finished!');
|
|
InspectorTest.completeTest();
|
|
})();
|