8b1a5681de
Bill kindly pointed out to me that v8windbg was not handling bit_field2 correctly. The issue was that the constexpr type for ElementsKind was, somewhat unsurprisingly, "ElementsKind", but v8windbg expected a fully- qualified type name like "v8::internal::ElementsKind". This change addresses the problem in two ways: 1. Update v8windbg's type resolution logic to resolve type names as if they were used in the v8::internal namespace. This makes it more consistent with how those type names are used in other generated Torque code, reducing surprises and the number of times we have to write `v8::internal::` in .tq files. 2. Add compile-time verification that any constexpr type name used as a string in class-debug-readers-tq.cc can also resolve as a type name. Bug: v8:9376 Change-Id: I349cd6ab586fd8345a1fa8bfc3989bb8e6376ab8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2063769 Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66633}
72 lines
2.4 KiB
C++
72 lines
2.4 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_TOOLS_DEBUG_HELPER_HEAP_CONSTANTS_H_
|
|
#define V8_TOOLS_DEBUG_HELPER_HEAP_CONSTANTS_H_
|
|
|
|
#include <cstdint>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "debug-helper.h"
|
|
#include "src/objects/instance-type.h"
|
|
|
|
namespace d = v8::debug_helper;
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace debug_helper_internal {
|
|
|
|
// ===== Functions generated by gen-heap-constants.py: =========================
|
|
|
|
// Returns the name of a known object, given its offset within the first page of
|
|
// the space, or empty string on failure.
|
|
std::string FindKnownObjectInOldSpace(uintptr_t offset);
|
|
std::string FindKnownObjectInReadOnlySpace(uintptr_t offset);
|
|
std::string FindKnownObjectInMapSpace(uintptr_t offset);
|
|
|
|
// In builds with pointer compression enabled, sets the *_first_page members in
|
|
// the HeapAddresses object. In other builds, does nothing.
|
|
void FillInUnknownHeapAddresses(d::HeapAddresses* heap_addresses,
|
|
uintptr_t any_uncompressed_ptr);
|
|
|
|
// Returns the instance type for the known Map, given its offset within the
|
|
// first page of the space, or empty string on failure.
|
|
int FindKnownMapInstanceTypeInMapSpace(uintptr_t offset);
|
|
int FindKnownMapInstanceTypeInReadOnlySpace(uintptr_t offset);
|
|
|
|
// ===== End of generated functions. ===========================================
|
|
|
|
// Returns a descriptive string if the given address matches a known object, or
|
|
// an empty string otherwise.
|
|
std::string FindKnownObject(uintptr_t address,
|
|
const d::HeapAddresses& heap_addresses);
|
|
|
|
struct KnownInstanceType {
|
|
enum class Confidence {
|
|
kLow,
|
|
kHigh,
|
|
};
|
|
KnownInstanceType() : confidence(Confidence::kLow) {}
|
|
KnownInstanceType(int type) : KnownInstanceType() {
|
|
if (type >= 0) {
|
|
confidence = Confidence::kHigh;
|
|
types.push_back(static_cast<v8::internal::InstanceType>(type));
|
|
}
|
|
}
|
|
Confidence confidence;
|
|
std::vector<v8::internal::InstanceType> types;
|
|
};
|
|
|
|
// Returns information about the instance type of the Map at the given address,
|
|
// based on the list of known Maps.
|
|
KnownInstanceType FindKnownMapInstanceTypes(
|
|
uintptr_t address, const d::HeapAddresses& heap_addresses);
|
|
|
|
} // namespace debug_helper_internal
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif
|