v8/test/debugger
Alexey Kozyatinskiy 0896586083 [inspector] improve return position of explicit return in non-async function
Goal of this CL: explicit return from non-async function has position after
return expression as return position (will unblock [1]).

BytecodeArrayBuilder has SetStatementPosition and SetExpressionPosition methods.
If one of these methods is called then next generated bytecode will get passed
position. It's general treatment for most cases.
Unfortunately it doesn't work for Returns:
- debugger requires source positions exactly on kReturn bytecode in stepping
  implementation,
- BytecodeGenerator::BuildReturn and BytecodeGenerator::BuildAsyncReturn
  generates more then one bytecode and general solution will put return position
  on first generated bytecode,
- it's not easy to split BuildReturn function into two parts to allow something
  like following in BytecodeGenerator::VisitReturnStatement since generated
  bytecodes are actually controlled by execution_control().
..->BuildReturnPrologue();
..->SetReturnPosition(stmt);
..->Return();

In this CL we pass ReturnStatement through ExecutionControl and use it for
position when we emit return bytecode right here.

So this CL only will improve return position for returns inside of non-async
functions, I'll address async functions later.

[1] https://chromium-review.googlesource.com/c/543161/

Change-Id: Iede512c120b00c209990bf50c20e7d23dc0d65db
Reviewed-on: https://chromium-review.googlesource.com/560738
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46687}
2017-07-14 19:10:13 +00:00
..
bugs/harmony [debug-wrapper] migrate some scope related tests 2016-12-14 07:20:33 +00:00
debug [inspector] improve return position of explicit return in non-async function 2017-07-14 19:10:13 +00:00
protocol [debugger] basic test infrastructure for new debugger test api. 2016-10-21 06:38:05 +00:00
regress [inspector] improve return position of explicit return in non-async function 2017-07-14 19:10:13 +00:00
wrapper [debugger] Various break-related functionality in test wrapper 2016-10-28 08:18:34 +00:00
debugger.gyp [debugger] basic test infrastructure for new debugger test api. 2016-10-21 06:38:05 +00:00
debugger.isolate [build] Remove remaining disable-inspector options in GN 2017-04-05 17:59:07 +00:00
debugger.status [inspector] improve return position of explicit return in non-async function 2017-07-14 19:10:13 +00:00
test-api.js [debugger] removed BreakPositionAlignment.STATEMENT_ALIGNED 2017-06-20 15:01:47 +00:00
testcfg.py Revert of [test] add --no-harness option to debugger tests. (patchset id:1 of https://codereview.chromium.org/2831083003/ ) 2017-05-08 15:06:42 +00:00