6651b95b41
Test that Managed objects get collected if they are not referenced any more. R=ulan@chromium.org Bug: v8:7628 Change-Id: I4a594ebe835071d76d7a6e2ddee6a6092b3e4a31 Reviewed-on: https://chromium-review.googlesource.com/999482 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52438}
99 lines
2.6 KiB
C++
99 lines
2.6 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <stdint.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include "src/managed.h"
|
|
|
|
#include "src/objects-inl.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
class DeleteRecorder {
|
|
public:
|
|
explicit DeleteRecorder(bool* deleted) : deleted_(deleted) {
|
|
*deleted_ = false;
|
|
}
|
|
~DeleteRecorder() { *deleted_ = true; }
|
|
static void Deleter(Isolate::ManagedObjectFinalizer* finalizer) {
|
|
delete *reinterpret_cast<DeleteRecorder**>(finalizer);
|
|
}
|
|
|
|
private:
|
|
bool* deleted_;
|
|
};
|
|
|
|
TEST(ManagedCollect) {
|
|
Isolate* isolate = CcTest::InitIsolateOnce();
|
|
bool deleted1 = false;
|
|
bool deleted2 = false;
|
|
DeleteRecorder* d1 = new DeleteRecorder(&deleted1);
|
|
DeleteRecorder* d2 = new DeleteRecorder(&deleted2);
|
|
Isolate::ManagedObjectFinalizer finalizer(d2, DeleteRecorder::Deleter);
|
|
isolate->RegisterForReleaseAtTeardown(&finalizer);
|
|
{
|
|
HandleScope scope(isolate);
|
|
auto handle = Managed<DeleteRecorder>::From(isolate, d1);
|
|
USE(handle);
|
|
}
|
|
|
|
CcTest::CollectAllAvailableGarbage();
|
|
|
|
CHECK(deleted1);
|
|
CHECK(!deleted2);
|
|
isolate->UnregisterFromReleaseAtTeardown(&finalizer);
|
|
delete d2;
|
|
CHECK(deleted2);
|
|
}
|
|
|
|
TEST(DisposeCollect) {
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator =
|
|
CcTest::InitIsolateOnce()->array_buffer_allocator();
|
|
|
|
v8::Isolate* isolate = v8::Isolate::New(create_params);
|
|
isolate->Enter();
|
|
Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
|
|
bool deleted1 = false;
|
|
bool deleted2 = false;
|
|
DeleteRecorder* d1 = new DeleteRecorder(&deleted1);
|
|
DeleteRecorder* d2 = new DeleteRecorder(&deleted2);
|
|
{
|
|
HandleScope scope(i_isolate);
|
|
auto handle = Managed<DeleteRecorder>::From(i_isolate, d1);
|
|
USE(handle);
|
|
}
|
|
Isolate::ManagedObjectFinalizer finalizer(d2, DeleteRecorder::Deleter);
|
|
i_isolate->RegisterForReleaseAtTeardown(&finalizer);
|
|
|
|
isolate->Exit();
|
|
isolate->Dispose();
|
|
CHECK(deleted1);
|
|
CHECK(deleted2);
|
|
}
|
|
|
|
TEST(CollectOnGC) {
|
|
i::Isolate* i_isolate = CcTest::InitIsolateOnce();
|
|
|
|
bool deleted = false;
|
|
{
|
|
HandleScope scope(i_isolate);
|
|
Managed<DeleteRecorder>::Allocate(i_isolate, &deleted);
|
|
}
|
|
// TODO(ulan): It should be possible to trigger a normal gc before the
|
|
// "critical" one, and the "critical" one should still process pending
|
|
// second-pass phantom callbacks (crbug.com/v8/7628).
|
|
// CcTest::CollectAllGarbage();
|
|
CcTest::CollectAllAvailableGarbage();
|
|
|
|
CHECK(deleted);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|