076687ab85
Add a "combination" assert scope class, which combines multiple existing assert scopes. This will allow scopes with functional overlap, e.g. DisallowGarbageCollection and DisallowHeapAllocation, to share an assert type rather than rather than requiring users to remember to set both. To demonstrate this, this redefines DisallowGarbageCollection to a combination of DisallowHeapAllocation and a new DisallowSafepoints, and some of the DCHECKs checking both are simplified to only check one or the other, as appropriate. The combination classes become subclasses of the existing assert scopes, so that they can be used in their place as e.g. a function parameter, e.g. DisallowGarbageCollection can be passed to a function expecting const DisallowHeapAllocation&. As a drive-by, this also changes the per-thread assert scopes to use a bitmask, rather than a bool array, to store their per-thread data. The per-isolate scopes already used a bitmask, so this unifies the behaviour between the two. Change-Id: I209e0a56f45e124c0ccadbd9fb77f39e070612fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534814 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#71231}
234 lines
6.4 KiB
C++
234 lines
6.4 KiB
C++
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/execution/isolate.h"
|
|
#include "src/handles/handles-inl.h"
|
|
#include "src/handles/handles.h"
|
|
#include "src/objects/foreign-inl.h"
|
|
#include "src/objects/managed.h"
|
|
#include "src/objects/maybe-object.h"
|
|
#include "src/objects/object-macros.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
// ------- Test simple argument evaluation order problems ---------
|
|
|
|
Handle<Object> CauseGC(Handle<Object> obj, Isolate* isolate) {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE, GarbageCollectionReason::kTesting);
|
|
|
|
return obj;
|
|
}
|
|
|
|
Object CauseGCRaw(Object obj, Isolate* isolate) {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE, GarbageCollectionReason::kTesting);
|
|
|
|
return obj;
|
|
}
|
|
|
|
Managed<Smi> CauseGCManaged(int i, Isolate* isolate) {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE, GarbageCollectionReason::kTesting);
|
|
|
|
return Managed<Smi>::cast(Smi::FromInt(i));
|
|
}
|
|
|
|
void TwoArgumentsFunction(Object a, Object b) {
|
|
a.Print();
|
|
b.Print();
|
|
}
|
|
|
|
void TestTwoArguments(Isolate* isolate) {
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
Handle<JSObject> obj2 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should cause warning.
|
|
TwoArgumentsFunction(*CauseGC(obj1, isolate), *CauseGC(obj2, isolate));
|
|
}
|
|
|
|
void TwoSizeTArgumentsFunction(size_t a, size_t b) {
|
|
USE(a);
|
|
USE(b);
|
|
}
|
|
|
|
void TestTwoSizeTArguments(Isolate* isolate) {
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
Handle<JSObject> obj2 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should cause warning.
|
|
TwoSizeTArgumentsFunction(sizeof(*CauseGC(obj1, isolate)),
|
|
sizeof(*CauseGC(obj2, isolate)));
|
|
}
|
|
|
|
// --------- Test problems with method arguments ----------
|
|
|
|
class SomeObject : public Object {
|
|
public:
|
|
void Method(Object a) { a.Print(); }
|
|
|
|
SomeObject& operator=(const Object& b) {
|
|
this->Print();
|
|
return *this;
|
|
}
|
|
|
|
DECL_CAST(SomeObject)
|
|
|
|
OBJECT_CONSTRUCTORS(SomeObject, Object);
|
|
};
|
|
|
|
void TestMethodCall(Isolate* isolate) {
|
|
SomeObject obj;
|
|
Handle<SomeObject> so = handle(obj, isolate);
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should cause warning.
|
|
so->Method(*CauseGC(obj1, isolate));
|
|
// Should cause warning.
|
|
so->Method(CauseGCRaw(*obj1, isolate));
|
|
}
|
|
|
|
void TestOperatorCall(Isolate* isolate) {
|
|
SomeObject obj;
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should not cause warning.
|
|
obj = *CauseGC(obj1, isolate);
|
|
}
|
|
|
|
// --------- Test for templated sub-classes of Object ----------
|
|
|
|
void TestFollowingTemplates(Isolate* isolate) {
|
|
// Should cause warning.
|
|
CauseGCManaged(42, isolate);
|
|
}
|
|
|
|
// --------- Test for correctly resolving virtual methods ----------
|
|
|
|
class BaseObject {
|
|
public:
|
|
virtual Handle<Object> VirtualCauseGC(Handle<Object> obj, Isolate* isolate) {
|
|
return obj;
|
|
}
|
|
};
|
|
|
|
class DerivedObject : public BaseObject {
|
|
public:
|
|
Handle<Object> VirtualCauseGC(Handle<Object> obj, Isolate* isolate) override {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE,
|
|
GarbageCollectionReason::kTesting);
|
|
|
|
return obj;
|
|
}
|
|
};
|
|
|
|
void TestFollowingVirtualFunctions(Isolate* isolate) {
|
|
DerivedObject derived;
|
|
BaseObject* base = &derived;
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
|
|
SomeObject so;
|
|
Handle<SomeObject> so_handle = handle(so, isolate);
|
|
// Should cause warning.
|
|
so_handle->Method(*derived.VirtualCauseGC(obj1, isolate));
|
|
// Should cause warning.
|
|
so_handle->Method(*base->VirtualCauseGC(obj1, isolate));
|
|
}
|
|
|
|
// --------- Test for correctly resolving static methods ----------
|
|
|
|
class SomeClass {
|
|
public:
|
|
static Handle<Object> StaticCauseGC(Handle<Object> obj, Isolate* isolate) {
|
|
isolate->heap()->CollectGarbage(OLD_SPACE,
|
|
GarbageCollectionReason::kTesting);
|
|
|
|
return obj;
|
|
}
|
|
};
|
|
|
|
void TestFollowingStaticFunctions(Isolate* isolate) {
|
|
SomeObject so;
|
|
Handle<SomeObject> so_handle = handle(so, isolate);
|
|
|
|
Handle<JSObject> obj1 = isolate->factory()->NewJSObjectWithNullProto();
|
|
// Should cause warning.
|
|
so_handle->Method(*SomeClass::StaticCauseGC(obj1, isolate));
|
|
}
|
|
|
|
// --------- Test basic dead variable analysis ----------
|
|
|
|
void TestDeadVarAnalysis(Isolate* isolate) {
|
|
JSObject raw_obj = *isolate->factory()->NewJSObjectWithNullProto();
|
|
CauseGCRaw(raw_obj, isolate);
|
|
|
|
// Should cause warning.
|
|
raw_obj.Print();
|
|
}
|
|
|
|
void TestGuardedDeadVarAnalysis(Isolate* isolate) {
|
|
JSObject raw_obj = *isolate->factory()->NewJSObjectWithNullProto();
|
|
|
|
// Note: having DisallowGarbageCollection with the same function as CauseGC
|
|
// normally doesn't make sense, but we want to test whether the gurads
|
|
// are recognized by GCMole.
|
|
DisallowGarbageCollection no_gc;
|
|
CauseGCRaw(raw_obj, isolate);
|
|
|
|
// Shouldn't cause warning.
|
|
raw_obj.Print();
|
|
}
|
|
|
|
void TestGuardedDeadVarAnalysisNotOnStack(Isolate* isolate) {
|
|
JSObject raw_obj = *isolate->factory()->NewJSObjectWithNullProto();
|
|
|
|
// {DisallowHeapAccess} has {DisallowHeapAllocation} as a superclass, so both
|
|
// are treated equally by gcmole.
|
|
DisallowHeapAccess no_gc;
|
|
CauseGCRaw(raw_obj, isolate);
|
|
|
|
// Shouldn't cause warning.
|
|
raw_obj.Print();
|
|
}
|
|
|
|
void TestGuardedDeadVarAnalysisNested(JSObject raw_obj, Isolate* isolate) {
|
|
CauseGCRaw(raw_obj, isolate);
|
|
|
|
// Should cause warning.
|
|
raw_obj.Print();
|
|
}
|
|
|
|
void TestGuardedDeadVarAnalysisCaller(Isolate* isolate) {
|
|
DisallowHeapAccess no_gc;
|
|
JSObject raw_obj = *isolate->factory()->NewJSObjectWithNullProto();
|
|
|
|
TestGuardedDeadVarAnalysisNested(raw_obj, isolate);
|
|
|
|
// Shouldn't cause warning.
|
|
raw_obj.Print();
|
|
}
|
|
|
|
JSObject GuardedAllocation(Isolate* isolate) {
|
|
DisallowHeapAllocation no_gc;
|
|
return *isolate->factory()->NewJSObjectWithNullProto();
|
|
}
|
|
|
|
void TestNestedDeadVarAnalysis(Isolate* isolate) {
|
|
JSObject raw_obj = GuardedAllocation(isolate);
|
|
CauseGCRaw(raw_obj, isolate);
|
|
|
|
// Should cause warning.
|
|
raw_obj.Print();
|
|
}
|
|
|
|
// Test that putting a guard in the middle of the function doesn't
|
|
// mistakenly cover the whole scope of the raw variable.
|
|
void TestGuardedDeadVarAnalysisMidFunction(Isolate* isolate) {
|
|
JSObject raw_obj = *isolate->factory()->NewJSObjectWithNullProto();
|
|
|
|
CauseGCRaw(raw_obj, isolate);
|
|
|
|
// Guarding the rest of the function from triggering a GC.
|
|
DisallowHeapAllocation no_gc;
|
|
// Should cause warning.
|
|
raw_obj.Print();
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|