87bc38e390
GCMole mistakenly thought that GC guards such as DisallowHeapAllocation covered the whole scope of the function they are declared in. This CL fixes the false negatives and adds appropriate testing. Bug: v8:10071 Change-Id: Iffb369977af90ca053a55ca8f451e037a4f460f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497451 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70763}
39 lines
1.5 KiB
Plaintext
39 lines
1.5 KiB
Plaintext
|
|
tools/gcmole/gcmole-test.cc:27:10: warning: Possibly dead variable.
|
|
return obj;
|
|
^
|
|
tools/gcmole/gcmole-test.cc:45:3: warning: Possible problem with evaluation order.
|
|
TwoArgumentsFunction(*CauseGC(obj1, isolate), *CauseGC(obj2, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:57:3: warning: Possible problem with evaluation order.
|
|
TwoSizeTArgumentsFunction(sizeof(*CauseGC(obj1, isolate)),
|
|
^
|
|
tools/gcmole/gcmole-test.cc:82:7: warning: Possible problem with evaluation order.
|
|
so->Method(*CauseGC(obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:84:7: warning: Possible problem with evaluation order.
|
|
so->Method(CauseGCRaw(*obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:128:14: warning: Possible problem with evaluation order.
|
|
so_handle->Method(*derived.VirtualCauseGC(obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:130:14: warning: Possible problem with evaluation order.
|
|
so_handle->Method(*base->VirtualCauseGC(obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:151:14: warning: Possible problem with evaluation order.
|
|
so_handle->Method(*SomeClass::StaticCauseGC(obj1, isolate));
|
|
^
|
|
tools/gcmole/gcmole-test.cc:161:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:193:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:216:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
tools/gcmole/gcmole-test.cc:229:3: warning: Possibly dead variable.
|
|
raw_obj.Print();
|
|
^
|
|
12 warnings generated.
|