fb922b1764
We don't currently inline array builtins if we detect any side effects between the load of the receiver map and the call to the builtin. The introduction of a map check allows us to be more permissive. Bug: v8:7250 Change-Id: I6b3f9243f6506eff45c0d727c47a7e8cb8765640 Reviewed-on: https://chromium-review.googlesource.com/849005 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#50620}
39 lines
1.3 KiB
JavaScript
39 lines
1.3 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
(() => {
|
|
|
|
// Make sure we inline the callback, pick up all possible TurboFan
|
|
// optimizations.
|
|
function RunOptFastReduce(multiple) {
|
|
// Use of variable multiple in the callback function forces
|
|
// context creation without escape analysis.
|
|
//
|
|
// Also, the arrow function requires inlining based on
|
|
// SharedFunctionInfo.
|
|
result = array.reduce((p, v, i, a) => p + multiple);
|
|
}
|
|
|
|
// Don't optimize because I want to optimize RunOptFastMap with a parameter
|
|
// to be used in the callback.
|
|
%NeverOptimizeFunction(OptFastReduce);
|
|
function OptFastReduce() { RunOptFastReduce(3); }
|
|
|
|
function side_effect(a) { return a; }
|
|
%NeverOptimizeFunction(side_effect);
|
|
function OptUnreliableReduce() {
|
|
result = array.reduce(func, side_effect(array));
|
|
}
|
|
|
|
DefineHigherOrderTests([
|
|
// name, test function, setup function, user callback
|
|
"DoubleReduce", mc("reduce"), DoubleSetup, (p, v, i, o) => p + v,
|
|
"SmiReduce", mc("reduce"), SmiSetup, (p, v, i, a) => p + 1,
|
|
"FastReduce", mc("reduce"), FastSetup, (p, v, i, a) => p + v,
|
|
"OptFastReduce", OptFastReduce, FastSetup, undefined,
|
|
"OptUnreliableReduce", OptUnreliableReduce, FastSetup,
|
|
(p, v, i, a) => p = v
|
|
]);
|
|
|
|
})();
|