07011cc4f0
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
and may causes nested Microtasks in a problematic way. E.g. that confuses
v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
respects the microtask suppressions.
As all existing tests don't call RunMicrotasks() in the suppressed situation
(like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
not affect to these tests.
Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
Reviewed-on: https://chromium-review.googlesource.com/c/1360095
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58068}
37 lines
993 B
JavaScript
37 lines
993 B
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --harmony-dynamic-import
|
|
|
|
var ran = false;
|
|
var x;
|
|
|
|
var body = "import('modules-skip-1.js').then(ns => { x = ns.life();" +
|
|
" ran = true;} ).catch(err => %AbortJS(err))"
|
|
var func = new Function(body);
|
|
func();
|
|
|
|
%PerformMicrotaskCheckpoint();
|
|
assertEquals(42, x);
|
|
assertTrue(ran);
|
|
|
|
var ran = false;
|
|
var body = "import('modules-skip-1.js').then(ns => { x = ns.life();" +
|
|
" ran = true;} ).catch(err => %AbortJS(err))"
|
|
eval("var func = new Function(body); func();");
|
|
|
|
%PerformMicrotaskCheckpoint();
|
|
assertEquals(42, x);
|
|
assertTrue(ran);
|
|
|
|
var ran = false;
|
|
var body = "eval(import('modules-skip-1.js').then(ns => { x = ns.life();" +
|
|
" ran = true;} ).catch(err => %AbortJS(err)))"
|
|
var func = new Function(body);
|
|
func();
|
|
|
|
%PerformMicrotaskCheckpoint();
|
|
assertEquals(42, x);
|
|
assertTrue(ran);
|