7101881269
This is a reland of 7a2c371383
Original change's description:
> [debug] introduced runtime side effect check
>
> This CL demonstrates minimum valuable addition to existing debug evaluate
> without side effects mechanism.
> With this CL user can evaluate expressions like:
> [a,b] // create any kind of temporary array literals
> [a,b].reduce((x,y) => x + y, 0); // use reduce method
> [1,2,3].fill(2); // change temporary arrays
>
> The core idea: any change of the object created during evaluation without
> side effects is side effect free. As soon as we try to store this temporary
> object to object existed before evaluation we will terminate execution.
>
> Implementation:
> - track all objects allocated during evaluation and mark them as temporary,
> - patch all bytecodes which change objects.
>
> A little more details (including performance analysis): [1].
>
> [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit#
>
> Bug: v8:7588
> Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111
> Reviewed-on: https://chromium-review.googlesource.com/972615
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52370}
Bug: v8:7588
Change-Id: Ibc92bf19155f2ddaedae39b0c576b994e84afcf8
Reviewed-on: https://chromium-review.googlesource.com/996760
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52373}
27 lines
631 B
Plaintext
27 lines
631 B
Plaintext
Tests how breakpoints and side effects live together.
|
|
Test breakpoint, should pause inside foo:
|
|
foo (test.js:3:2)
|
|
(anonymous) (:0:0)
|
|
|
|
Run foo with no side effects:
|
|
{
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|
|
|
|
Test breakpoint after run with side effect check:
|
|
foo (test.js:3:2)
|
|
(anonymous) (:0:0)
|
|
|
|
Run foo with no side effects after debugger disabled:
|
|
{
|
|
className : EvalError
|
|
description : EvalError: Possible side-effect in debug-evaluate
|
|
objectId : <objectId>
|
|
subtype : error
|
|
type : object
|
|
}
|