6f028d6a4e
Also removes can_execute_on_background_thread() since all compilation jobs can now do that. Part of the work towards enabling off-thread bytecode compilation. BUG=v8:5203 Change-Id: I6a52c26d599ce74482b5fb49926603cb326f1e31 Reviewed-on: https://chromium-review.googlesource.com/731285 Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48826}
98 lines
2.9 KiB
C++
98 lines
2.9 KiB
C++
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/compiler-dispatcher/optimizing-compile-dispatcher.h"
|
|
|
|
#include "src/base/atomic-utils.h"
|
|
#include "src/base/platform/semaphore.h"
|
|
#include "src/compilation-info.h"
|
|
#include "src/compiler.h"
|
|
#include "src/handles.h"
|
|
#include "src/isolate.h"
|
|
#include "src/objects-inl.h"
|
|
#include "src/parsing/parse-info.h"
|
|
#include "test/unittests/test-helpers.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
typedef TestWithContext OptimizingCompileDispatcherTest;
|
|
|
|
namespace {
|
|
|
|
class BlockingCompilationJob : public CompilationJob {
|
|
public:
|
|
BlockingCompilationJob(Isolate* isolate, Handle<JSFunction> function)
|
|
: CompilationJob(isolate->stack_guard()->real_climit(), &parse_info_,
|
|
&info_, "BlockingCompilationJob",
|
|
State::kReadyToExecute),
|
|
shared_(function->shared()),
|
|
parse_info_(shared_),
|
|
info_(parse_info_.zone(), function->GetIsolate(), shared_, function),
|
|
blocking_(false),
|
|
semaphore_(0) {}
|
|
~BlockingCompilationJob() override = default;
|
|
|
|
bool IsBlocking() const { return blocking_.Value(); }
|
|
void Signal() { semaphore_.Signal(); }
|
|
|
|
// CompilationJob implementation.
|
|
Status PrepareJobImpl() override {
|
|
UNREACHABLE();
|
|
}
|
|
|
|
Status ExecuteJobImpl() override {
|
|
blocking_.SetValue(true);
|
|
semaphore_.Wait();
|
|
blocking_.SetValue(false);
|
|
return SUCCEEDED;
|
|
}
|
|
|
|
Status FinalizeJobImpl() override { return SUCCEEDED; }
|
|
|
|
private:
|
|
Handle<SharedFunctionInfo> shared_;
|
|
ParseInfo parse_info_;
|
|
CompilationInfo info_;
|
|
base::AtomicValue<bool> blocking_;
|
|
base::Semaphore semaphore_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(BlockingCompilationJob);
|
|
};
|
|
|
|
} // namespace
|
|
|
|
TEST_F(OptimizingCompileDispatcherTest, Construct) {
|
|
OptimizingCompileDispatcher dispatcher(i_isolate());
|
|
ASSERT_TRUE(OptimizingCompileDispatcher::Enabled());
|
|
ASSERT_TRUE(dispatcher.IsQueueAvailable());
|
|
}
|
|
|
|
TEST_F(OptimizingCompileDispatcherTest, NonBlockingFlush) {
|
|
Handle<JSFunction> fun = Handle<JSFunction>::cast(test::RunJS(
|
|
isolate(), "function f() { function g() {}; return g;}; f();"));
|
|
BlockingCompilationJob* job = new BlockingCompilationJob(i_isolate(), fun);
|
|
|
|
OptimizingCompileDispatcher dispatcher(i_isolate());
|
|
ASSERT_TRUE(OptimizingCompileDispatcher::Enabled());
|
|
ASSERT_TRUE(dispatcher.IsQueueAvailable());
|
|
dispatcher.QueueForOptimization(job);
|
|
|
|
// Busy-wait for the job to run on a background thread.
|
|
while (!job->IsBlocking()) {
|
|
}
|
|
|
|
// Should not block.
|
|
dispatcher.Flush(OptimizingCompileDispatcher::BlockingBehavior::kDontBlock);
|
|
|
|
// Unblock the job & finish.
|
|
job->Signal();
|
|
dispatcher.Stop();
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|