f774d8c56f
Once we enabled --turbo by default we need to turn all the implications off with --no-turbo as well. Chrome sets flags in V8 using SetFlagFromString, which enforces the implications each time it is called. Therefore, if --turbo is enabled by default, and an unrelated flag is set, the turbo implications are enabled but not later disabled if we set --no-turbo. To fix this, add negative implications as well. BUG=chromium:692409 Change-Id: Iadb0ca542f49ba65c7419cda8c7a03636a8d5ba9 Reviewed-on: https://chromium-review.googlesource.com/451320 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#43655}
70 lines
1.8 KiB
JavaScript
70 lines
1.8 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --ignition --turbo
|
|
|
|
// Test that declaring local variables in IIFEs works with
|
|
// side-effect free debug-evaluate.
|
|
|
|
Debug = debug.Debug
|
|
|
|
var exception = null;
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
function success(expectation, source) {
|
|
assertEquals(expectation,
|
|
exec_state.frame(0).evaluate(source, true).value());
|
|
}
|
|
function fail(source) {
|
|
assertThrows(() => exec_state.frame(0).evaluate(source, true),
|
|
EvalError);
|
|
}
|
|
// Declaring 'a' sets a property to the global object.
|
|
fail("var a = 3");
|
|
exec_state.frame(0).evaluate("var a = 2", false);
|
|
assertEquals(2, a);
|
|
// Wrapping into an IIFE would be fine, since 'a' is local.
|
|
success(100,
|
|
`(function(x) {
|
|
var a = 0;
|
|
for (var i = 0; i < x; i++) {
|
|
a += x;
|
|
}
|
|
return a;
|
|
})(10);`);
|
|
success(100,
|
|
`(x => {
|
|
let a = 0;
|
|
for (var i = 0; i < x; i++) {
|
|
a += x;
|
|
}
|
|
return a;
|
|
})(10);`);
|
|
// Not using 'var' to declare would make the access go to global object.
|
|
fail( `(function(x) {
|
|
a = 0;
|
|
for (var i = 0; i < x; i++) {
|
|
a += x;
|
|
}
|
|
return a;
|
|
})(10);`);
|
|
} catch (e) {
|
|
exception = e;
|
|
print(e, e.stack);
|
|
};
|
|
};
|
|
|
|
// Add the debug event listener.
|
|
Debug.setListener(listener);
|
|
|
|
function f() {
|
|
debugger;
|
|
};
|
|
|
|
f();
|
|
|
|
assertNull(exception);
|