311808eefc
This CL simplifies the implementation of inlined DataView methods in TurboFan. It removes the explicit exception handling, and just deopts and relies on the baseline code to handle exceptions instead. It also adapts the DataView test files in mjsunit/compiler/ accordingly. Change-Id: I013c76970e1480df2b755d17d397bd0f9f26f0ec Reviewed-on: https://chromium-review.googlesource.com/1148207 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54648}
59 lines
1.2 KiB
JavaScript
59 lines
1.2 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt --no-always-opt
|
|
|
|
// Check that there are no deopt loops for DataView methods.
|
|
|
|
var buffer = new ArrayBuffer(64);
|
|
var dataview = new DataView(buffer, 8, 24);
|
|
|
|
// Check DataView getters.
|
|
|
|
function readUint8(offset) {
|
|
return dataview.getUint8(offset);
|
|
}
|
|
|
|
function warmupRead(f) {
|
|
f(0);
|
|
f(1);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
f(2);
|
|
f(3);
|
|
}
|
|
|
|
warmupRead(readUint8);
|
|
assertOptimized(readUint8);
|
|
readUint8(0.5); // Deopts.
|
|
assertUnoptimized(readUint8);
|
|
|
|
warmupRead(readUint8);
|
|
assertOptimized(readUint8);
|
|
readUint8(1.5); // Doesn't deopt because getUint8 didn't get inlined this time.
|
|
assertOptimized(readUint8);
|
|
|
|
// Check DataView setters.
|
|
|
|
function writeUint8(offset, value) {
|
|
dataview.setUint8(offset, value);
|
|
}
|
|
|
|
function warmupWrite(f) {
|
|
f(0, 0);
|
|
f(0, 1);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
f(0, 2);
|
|
f(0, 3);
|
|
}
|
|
|
|
warmupWrite(writeUint8);
|
|
assertOptimized(writeUint8);
|
|
writeUint8(0.5, 0); // Deopts.
|
|
assertUnoptimized(writeUint8);
|
|
|
|
warmupWrite(writeUint8);
|
|
assertOptimized(writeUint8);
|
|
writeUint8(1.5, 0); // Doesn't deopt.
|
|
assertOptimized(writeUint8);
|