1e4282db0d
This is a reland of f7a1932ef9
There was a wpt test in Chrome that expected the incorrect behavior.
I disable the test in https://crrev.com/c/2264418 so that we can land
the fix here.
Original change's description:
> [wasm] Re-exported globals preserve their identity
>
> V8 fails a recently added spec test that when an imported global get
> re-exported, it should preserve its identity. This CL fixes the behavior
> in V8.
>
> Drive-by change: fix the object printer of globals: a global which
> stores a reference type only has a tagged buffer, a global which stores
> a value type only has an untagged buffer.
>
> R=clemensb@chromium.org
>
> Bug: v8:10556
> Change-Id: I949d147fe4395610cfec6cf60082e1faecb23036
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235702
> Commit-Queue: Andreas Haas <ahaas@chromium.org>
> Reviewed-by: Clemens Backes <clemensb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#68513}
Bug: v8:10556
Change-Id: I8e1b08fc9f72dde166cba167e6e320e714796769
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264097
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68552}
32 lines
1.1 KiB
JavaScript
32 lines
1.1 KiB
JavaScript
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
load('test/mjsunit/wasm/wasm-module-builder.js');
|
|
|
|
const global1 = new WebAssembly.Global({value: 'i32', mutable: true}, 14);
|
|
const global2 = new WebAssembly.Global({value: 'i32', mutable: true}, 15);
|
|
const global3 = new WebAssembly.Global({value: 'i32', mutable: true}, 32);
|
|
|
|
const builder = new WasmModuleBuilder();
|
|
|
|
// Two additional globals, so that global-index != export-index.
|
|
builder.addImportedGlobal('module', 'global1', kWasmI32, true);
|
|
builder.addImportedGlobal('module', 'global2', kWasmI32, true);
|
|
const globalIndex =
|
|
builder.addImportedGlobal('module', 'global3', kWasmI32, true);
|
|
builder.addExportOfKind('exportedGlobal', kExternalGlobal, globalIndex);
|
|
|
|
const buffer = builder.toBuffer();
|
|
|
|
const module = new WebAssembly.Module(buffer);
|
|
const instance = new WebAssembly.Instance(module, {
|
|
'module': {
|
|
'global1': global1,
|
|
'global2': global2,
|
|
'global3': global3,
|
|
}
|
|
});
|
|
|
|
assertEquals(global3, instance.exports.exportedGlobal);
|