ecaac3292f
This change adds Torque field definitions for ScopeInfo and begins to use the Torque-generated accessors in some places. It does not change the in-memory layout of ScopeInfo. Torque compiler changes: - Fix an issue where the parser created constexpr types for classes based on the class name rather than the `generates` clause. This meant that generated accessors referred to the imaginary type HashTable rather than the real C++ type FixedArray. - Don't pass Isolate* through the generated runtime functions that implement Torque macros. Maybe we'll need it eventually, but we don't right now and it complicates a lot of things. - Don't emit `kSomeFieldOffset` if some_field has an unknown offset. Instead, emit a member function `SomeFieldOffset()` which fetches the slice for some_field and returns its offset. - Emit an `AllocatedSize()` member function for classes which have complex length expressions. It fetches the slice for the last field and performs the multiply&add to compute the total object size. - Emit field accessors for fields with complex length expressions, using the new offset functions. - Fix a few minor bugs where Torque can write uncompilable code. With this change, most code still treats ScopeInfo like a FixedArray, so I would like to follow up with some additional changes: 1. Generate a GC visitor for ScopeInfo and use it 2. Generate accessors for struct-typed fields (indexed or otherwise), and use them 3. Get rid of the FixedArray-style get and set accessors; use TaggedField::load and similar instead 4. Inherit from HeapObject rather than FixedArrayBase to remove the unnecessary `length` field After that, there will only be one ugly part left: initialization. I think it's possible to generate a factory function that takes a bunch of iterator parameters and returns a fully-formed, verifiably correct ScopeInfo instance, but doing so is more complicated than the four mostly-mechanical changes listed above. Bug: v8:7793 Change-Id: I55fcfe9189e4d1613c68d49e378da5dc02597b36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2357758 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72187}
104 lines
4.2 KiB
C++
104 lines
4.2 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// This file contains implementations of a few macros that are defined
|
|
// as external in Torque, so that generated debug code can work.
|
|
|
|
#ifndef V8_TORQUE_DEBUG_MACRO_SHIMS_H_
|
|
#define V8_TORQUE_DEBUG_MACRO_SHIMS_H_
|
|
|
|
#include "src/objects/smi.h"
|
|
#include "tools/debug_helper/debug-helper-internal.h"
|
|
|
|
// For Object::ReadField<T>.
|
|
#define READ_FIELD_OR_FAIL(Type, destination, accessor, object, offset) \
|
|
do { \
|
|
Type value{}; \
|
|
d::MemoryAccessResult validity = \
|
|
accessor(object - kHeapObjectTag + offset, \
|
|
reinterpret_cast<Type*>(&value), sizeof(value)); \
|
|
if (validity != d::MemoryAccessResult::kOk) return {validity, {}}; \
|
|
destination = value; \
|
|
} while (false)
|
|
|
|
// For TaggedField<T>::load.
|
|
#define READ_TAGGED_FIELD_OR_FAIL(destination, accessor, object, offset) \
|
|
do { \
|
|
Tagged_t value{}; \
|
|
d::MemoryAccessResult validity = \
|
|
accessor(object - kHeapObjectTag + offset, \
|
|
reinterpret_cast<uint8_t*>(&value), sizeof(value)); \
|
|
if (validity != d::MemoryAccessResult::kOk) return {validity, {}}; \
|
|
destination = EnsureDecompressed(value, object); \
|
|
} while (false)
|
|
|
|
// Process Value struct.
|
|
#define ASSIGN_OR_RETURN(dest, val) \
|
|
do { \
|
|
if ((val).validity != d::MemoryAccessResult::kOk) \
|
|
return {(val).validity, {}}; \
|
|
dest = (val).value; \
|
|
} while (false)
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace debug_helper_internal {
|
|
namespace TorqueDebugMacroShims {
|
|
namespace CodeStubAssembler {
|
|
|
|
inline Value<bool> BoolConstant(d::MemoryAccessor accessor, bool b) {
|
|
return {d::MemoryAccessResult::kOk, b};
|
|
}
|
|
inline Value<intptr_t> ChangeInt32ToIntPtr(d::MemoryAccessor accessor,
|
|
int32_t i) {
|
|
return {d::MemoryAccessResult::kOk, i};
|
|
}
|
|
inline Value<uintptr_t> ChangeUint32ToWord(d::MemoryAccessor accessor,
|
|
uint32_t u) {
|
|
return {d::MemoryAccessResult::kOk, u};
|
|
}
|
|
inline Value<intptr_t> IntPtrAdd(d::MemoryAccessor accessor, intptr_t a,
|
|
intptr_t b) {
|
|
return {d::MemoryAccessResult::kOk, a + b};
|
|
}
|
|
inline Value<intptr_t> IntPtrMul(d::MemoryAccessor accessor, intptr_t a,
|
|
intptr_t b) {
|
|
return {d::MemoryAccessResult::kOk, a * b};
|
|
}
|
|
inline Value<intptr_t> Signed(d::MemoryAccessor accessor, uintptr_t u) {
|
|
return {d::MemoryAccessResult::kOk, static_cast<intptr_t>(u)};
|
|
}
|
|
inline Value<int32_t> SmiUntag(d::MemoryAccessor accessor, uintptr_t s_t) {
|
|
Smi s(s_t);
|
|
return {d::MemoryAccessResult::kOk, s.value()};
|
|
}
|
|
inline Value<bool> UintPtrLessThan(d::MemoryAccessor accessor, uintptr_t a,
|
|
uintptr_t b) {
|
|
return {d::MemoryAccessResult::kOk, a < b};
|
|
}
|
|
inline Value<uint32_t> Unsigned(d::MemoryAccessor accessor, int32_t s) {
|
|
return {d::MemoryAccessResult::kOk, static_cast<uint32_t>(s)};
|
|
}
|
|
#if V8_HOST_ARCH_64_BIT
|
|
inline Value<uintptr_t> Unsigned(d::MemoryAccessor accessor, intptr_t s) {
|
|
return {d::MemoryAccessResult::kOk, static_cast<uintptr_t>(s)};
|
|
}
|
|
#endif
|
|
inline Value<bool> Word32Equal(d::MemoryAccessor accessor, uint32_t a,
|
|
uint32_t b) {
|
|
return {d::MemoryAccessResult::kOk, a == b};
|
|
}
|
|
inline Value<bool> Word32NotEqual(d::MemoryAccessor accessor, uint32_t a,
|
|
uint32_t b) {
|
|
return {d::MemoryAccessResult::kOk, a != b};
|
|
}
|
|
|
|
} // namespace CodeStubAssembler
|
|
} // namespace TorqueDebugMacroShims
|
|
} // namespace debug_helper_internal
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_TORQUE_DEBUG_MACRO_SHIMS_H_
|