8fdb23873b
This reverts commit5611f70b3d. Reason for revert: flaky tests: v8:9588, v8:9587 Original change's description: > "Reland x4 [arraybuffer] Rearchitect backing store ownership" > > This is a reland ofbc33f5aeba> > Contributed by titzer@chromium.org > > Original change's description: > > [arraybuffer] Rearchitect backing store ownership > > > > This CL completely rearchitects the ownership of array buffer backing stores, > > consolidating ownership into a {BackingStore} C++ object that is tracked > > throughout V8 using unique_ptr and shared_ptr where appropriate. > > > > Overall, lifetime management is simpler and more explicit. The numerous > > ways that array buffers were initialized have been streamlined to one > > Attach() method on JSArrayBuffer. The array buffer tracker in the > > GC implementation now manages std::shared_ptr<BackingStore> pointers, > > and the construction and destruction of the BackingStore object itself > > handles the underlying page or embedder-allocated memory. > > > > The embedder API remains unchanged for now. We use the > > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > > keep the backing store alive properly, even in the case of aliases > > from live heap objects. Thus the embedder has a lower chance of making > > a mistake. Long-term, we should move the embedder to a model where they > > manage backing stores using shared_ptr to an opaque backing store object. > > TBR=yangguo@chromium.org > > BUG=v8:9380,v8:9221,chromium:986318 > > Change-Id: If671a4a9ca0476e8f084efae46e0d2bf99ed99ef > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731005 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63041} TBR=ulan@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9380, v8:9221, chromium:986318 Change-Id: Ic7381239f4e90d0c437b7e47a5ac6e8bce60f882 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1736747 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63081}
92 lines
3.2 KiB
C++
92 lines
3.2 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/heap/heap-inl.h"
|
|
#include "src/objects/cell.h"
|
|
#include "src/objects/feedback-cell.h"
|
|
#include "src/objects/script.h"
|
|
#include "src/roots/roots-inl.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
namespace {
|
|
AllocationSpace GetSpaceFromObject(Object object) {
|
|
DCHECK(object.IsHeapObject());
|
|
return MemoryChunk::FromHeapObject(HeapObject::cast(object))
|
|
->owner_identity();
|
|
}
|
|
} // namespace
|
|
|
|
#define CHECK_IN_RO_SPACE(type, name, CamelName) \
|
|
HeapObject name = roots.name(); \
|
|
CHECK_EQ(RO_SPACE, GetSpaceFromObject(name));
|
|
|
|
// The following tests check that all the roots accessible via ReadOnlyRoots are
|
|
// in RO_SPACE.
|
|
TEST(TestReadOnlyRoots) {
|
|
ReadOnlyRoots roots(CcTest::i_isolate());
|
|
|
|
READ_ONLY_ROOT_LIST(CHECK_IN_RO_SPACE)
|
|
}
|
|
|
|
#undef CHECK_IN_RO_SPACE
|
|
|
|
namespace {
|
|
bool IsInitiallyMutable(Factory* factory, Address object_address) {
|
|
// Entries in this list are in STRONG_MUTABLE_MOVABLE_ROOT_LIST, but may
|
|
// initially point to objects that are in RO_SPACE.
|
|
#define INITIALLY_READ_ONLY_ROOT_LIST(V) \
|
|
V(api_private_symbol_table) \
|
|
V(api_symbol_table) \
|
|
V(builtins_constants_table) \
|
|
V(current_microtask) \
|
|
V(detached_contexts) \
|
|
V(dirty_js_finalization_groups) \
|
|
V(feedback_vectors_for_profiling_tools) \
|
|
V(materialized_objects) \
|
|
V(noscript_shared_function_infos) \
|
|
V(public_symbol_table) \
|
|
V(retained_maps) \
|
|
V(retaining_path_targets) \
|
|
V(serialized_global_proxy_sizes) \
|
|
V(serialized_objects) \
|
|
V(weak_refs_keep_during_job)
|
|
|
|
#define TEST_CAN_BE_READ_ONLY(name) \
|
|
if (factory->name().address() == object_address) return false;
|
|
INITIALLY_READ_ONLY_ROOT_LIST(TEST_CAN_BE_READ_ONLY)
|
|
#undef TEST_CAN_BE_READ_ONLY
|
|
#undef INITIALLY_READ_ONLY_ROOT_LIST
|
|
return true;
|
|
}
|
|
} // namespace
|
|
|
|
// The CHECK_EQ line is there just to ensure that the root is publicly
|
|
// accessible from Heap, but ultimately the factory is used as it provides
|
|
// handles that have the address in the root table.
|
|
#define CHECK_NOT_IN_RO_SPACE(type, name, CamelName) \
|
|
Handle<Object> name = factory->name(); \
|
|
CHECK_EQ(*name, heap->name()); \
|
|
if (name->IsHeapObject() && IsInitiallyMutable(factory, name.address()) && \
|
|
!name->IsUndefined(CcTest::i_isolate())) { \
|
|
CHECK_NE(RO_SPACE, GetSpaceFromObject(HeapObject::cast(*name))); \
|
|
}
|
|
|
|
// The following tests check that all the roots accessible via public Heap
|
|
// accessors are not in RO_SPACE with the exception of the objects listed in
|
|
// INITIALLY_READ_ONLY_ROOT_LIST.
|
|
TEST(TestHeapRootsNotReadOnly) {
|
|
Factory* factory = CcTest::i_isolate()->factory();
|
|
Heap* heap = CcTest::i_isolate()->heap();
|
|
|
|
MUTABLE_ROOT_LIST(CHECK_NOT_IN_RO_SPACE)
|
|
}
|
|
|
|
#undef CHECK_NOT_IN_RO_SPACE
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|