6f39ab8911
This adds support for Promise.all() to --async-stack-traces (also at
zero cost, since we can derive the relevant information from the resolve
element closure and context). In case of `Promise.all(a)` the stack
trace even tells you which element of `a` is responsible, for example
```js
async function fine() {}
async function thrower() { await fine(); throw new Error(); }
async function test() { await Promise.all([fine(), thrower()]); }
```
will generate the following stack trace
```
Error
at thrower (something.js:1:9)
at async Promise.all (index 1)
at async test (something.js:3:3)
```
so it not only shows the async Promise.all() frames, but even tells the
user exactly that the second element of `[fine(), thrower()]` is the
relevant one.
Bug: v8:7522
Change-Id: I279a845888e06053cf0e3c9338ab71caabaabf45
Reviewed-on: https://chromium-review.googlesource.com/c/1299248
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57023}
36 lines
1013 B
JavaScript
36 lines
1013 B
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --async-stack-traces
|
|
|
|
// Check that Error.prepareStackTrace properly exposes async
|
|
// stack frames and special Promise.all() stack frames.
|
|
Error.prepareStackTrace = (e, frames) => {
|
|
assertEquals(two, frames[0].getFunction());
|
|
assertEquals(two.name, frames[0].getFunctionName());
|
|
assertFalse(frames[0].isAsync());
|
|
assertEquals(Promise.all, frames[1].getFunction());
|
|
assertTrue(frames[1].isAsync());
|
|
assertTrue(frames[1].isPromiseAll());
|
|
assertEquals(one, frames[2].getFunction());
|
|
assertEquals(one.name, frames[2].getFunctionName());
|
|
assertTrue(frames[2].isAsync());
|
|
return frames;
|
|
};
|
|
|
|
async function one(x) {
|
|
return await Promise.all([two(x)]);
|
|
}
|
|
|
|
async function two(x) {
|
|
try {
|
|
x = await x;
|
|
throw new Error();
|
|
} catch (e) {
|
|
return e.stack;
|
|
}
|
|
}
|
|
|
|
one(1).catch(e => setTimeout(_ => {throw e}, 0));
|