ec06bb6ce5
This is a reland of d1b27019d3
Fixes include:
Adding missing file to bazel build
Forward-declaring classing before friend-classing them to fix win/gcc
Add missing v8-isolate.h include for vtune builds
Original change's description:
> [include] Split out v8.h
>
> This moves every single class/function out of include/v8.h into a
> separate header in include/, which v8.h then includes so that
> externally nothing appears to have changed.
>
> Every include of v8.h from inside v8 has been changed to a more
> fine-grained include.
>
> Previously inline functions defined at the bottom of v8.h would call
> private non-inline functions in the V8 class. Since that class is now
> in v8-initialization.h and is rarely included (as that would create
> dependency cycles), this is not possible and so those methods have been
> moved out of the V8 class into the namespace v8::api_internal.
>
> None of the previous files in include/ now #include v8.h, which means
> if embedders were relying on this transitive dependency then it will
> give compile failures.
>
> v8-inspector.h does depend on v8-scripts.h for the time being to ensure
> that Chrome continue to compile but that change will be reverted once
> those transitive #includes in chrome are changed to include it directly.
>
> Full design:
> https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing
>
> Bug: v8:11965
> Change-Id: I53b84b29581632710edc80eb11f819c2097a2877
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Dan Elphick <delphick@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76424}
Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit
Bug: v8:11965
Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76460}
158 lines
6.3 KiB
C++
158 lines
6.3 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "include/v8-function.h"
|
|
#include "src/api/api-inl.h"
|
|
#include "src/codegen/code-factory.h"
|
|
#include "src/codegen/compiler.h"
|
|
#include "src/codegen/optimized-compilation-info.h"
|
|
#include "src/codegen/script-details.h"
|
|
#include "src/compiler/common-operator.h"
|
|
#include "src/compiler/graph.h"
|
|
#include "src/compiler/linkage.h"
|
|
#include "src/compiler/machine-operator.h"
|
|
#include "src/compiler/node.h"
|
|
#include "src/compiler/operator.h"
|
|
#include "src/compiler/pipeline.h"
|
|
#include "src/compiler/schedule.h"
|
|
#include "src/objects/objects-inl.h"
|
|
#include "src/parsing/parse-info.h"
|
|
#include "src/zone/zone.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
static Operator dummy_operator(IrOpcode::kParameter, Operator::kNoWrite,
|
|
"dummy", 0, 0, 0, 0, 0, 0);
|
|
|
|
// So we can get a real JS function.
|
|
static Handle<JSFunction> Compile(const char* source) {
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Handle<String> source_code = isolate->factory()
|
|
->NewStringFromUtf8(base::CStrVector(source))
|
|
.ToHandleChecked();
|
|
Handle<SharedFunctionInfo> shared =
|
|
Compiler::GetSharedFunctionInfoForScript(
|
|
isolate, source_code, ScriptDetails(),
|
|
v8::ScriptCompiler::kNoCompileOptions,
|
|
ScriptCompiler::kNoCacheNoReason, NOT_NATIVES_CODE)
|
|
.ToHandleChecked();
|
|
return Factory::JSFunctionBuilder{isolate, shared, isolate->native_context()}
|
|
.Build();
|
|
}
|
|
|
|
|
|
TEST(TestLinkageCreate) {
|
|
HandleAndZoneScope handles;
|
|
Handle<JSFunction> function = Compile("a + b");
|
|
Handle<SharedFunctionInfo> shared(function->shared(), handles.main_isolate());
|
|
OptimizedCompilationInfo info(handles.main_zone(), function->GetIsolate(),
|
|
shared, function, CodeKind::TURBOFAN);
|
|
auto call_descriptor = Linkage::ComputeIncoming(info.zone(), &info);
|
|
CHECK(call_descriptor);
|
|
}
|
|
|
|
|
|
TEST(TestLinkageJSFunctionIncoming) {
|
|
const char* sources[] = {"(function() { })", "(function(a) { })",
|
|
"(function(a,b) { })", "(function(a,b,c) { })"};
|
|
|
|
for (int i = 0; i < 3; i++) {
|
|
HandleAndZoneScope handles;
|
|
Handle<JSFunction> function =
|
|
Handle<JSFunction>::cast(v8::Utils::OpenHandle(
|
|
*v8::Local<v8::Function>::Cast(CompileRun(sources[i]))));
|
|
Handle<SharedFunctionInfo> shared(function->shared(),
|
|
handles.main_isolate());
|
|
OptimizedCompilationInfo info(handles.main_zone(), function->GetIsolate(),
|
|
shared, function, CodeKind::TURBOFAN);
|
|
auto call_descriptor = Linkage::ComputeIncoming(info.zone(), &info);
|
|
CHECK(call_descriptor);
|
|
|
|
CHECK_EQ(1 + i, static_cast<int>(call_descriptor->JSParameterCount()));
|
|
CHECK_EQ(1, static_cast<int>(call_descriptor->ReturnCount()));
|
|
CHECK_EQ(Operator::kNoProperties, call_descriptor->properties());
|
|
CHECK_EQ(true, call_descriptor->IsJSFunctionCall());
|
|
}
|
|
}
|
|
|
|
|
|
TEST(TestLinkageJSCall) {
|
|
HandleAndZoneScope handles;
|
|
Handle<JSFunction> function = Compile("a + c");
|
|
Handle<SharedFunctionInfo> shared(function->shared(), handles.main_isolate());
|
|
OptimizedCompilationInfo info(handles.main_zone(), function->GetIsolate(),
|
|
shared, function, CodeKind::TURBOFAN);
|
|
|
|
for (int i = 0; i < 32; i++) {
|
|
auto call_descriptor = Linkage::GetJSCallDescriptor(
|
|
info.zone(), false, i, CallDescriptor::kNoFlags);
|
|
CHECK(call_descriptor);
|
|
CHECK_EQ(i, static_cast<int>(call_descriptor->JSParameterCount()));
|
|
CHECK_EQ(1, static_cast<int>(call_descriptor->ReturnCount()));
|
|
CHECK_EQ(Operator::kNoProperties, call_descriptor->properties());
|
|
CHECK_EQ(true, call_descriptor->IsJSFunctionCall());
|
|
}
|
|
}
|
|
|
|
|
|
TEST(TestLinkageRuntimeCall) {
|
|
// TODO(titzer): test linkage creation for outgoing runtime calls.
|
|
}
|
|
|
|
|
|
TEST(TestLinkageStubCall) {
|
|
// TODO(bbudge) Add tests for FP registers.
|
|
Isolate* isolate = CcTest::InitIsolateOnce();
|
|
Zone zone(isolate->allocator(), ZONE_NAME);
|
|
Callable callable = Builtins::CallableFor(isolate, Builtin::kToNumber);
|
|
OptimizedCompilationInfo info(base::ArrayVector("test"), &zone,
|
|
CodeKind::FOR_TESTING);
|
|
auto call_descriptor = Linkage::GetStubCallDescriptor(
|
|
&zone, callable.descriptor(), 0, CallDescriptor::kNoFlags,
|
|
Operator::kNoProperties);
|
|
CHECK(call_descriptor);
|
|
CHECK_EQ(0, static_cast<int>(call_descriptor->ParameterSlotCount()));
|
|
CHECK_EQ(1, static_cast<int>(call_descriptor->ReturnCount()));
|
|
CHECK_EQ(Operator::kNoProperties, call_descriptor->properties());
|
|
CHECK_EQ(false, call_descriptor->IsJSFunctionCall());
|
|
|
|
CHECK_EQ(call_descriptor->GetParameterType(0), MachineType::AnyTagged());
|
|
CHECK_EQ(call_descriptor->GetReturnType(0), MachineType::AnyTagged());
|
|
// TODO(titzer): test linkage creation for outgoing stub calls.
|
|
}
|
|
|
|
#if V8_ENABLE_WEBASSEMBLY
|
|
TEST(TestFPLinkageStubCall) {
|
|
Isolate* isolate = CcTest::InitIsolateOnce();
|
|
Zone zone(isolate->allocator(), ZONE_NAME);
|
|
Callable callable =
|
|
Builtins::CallableFor(isolate, Builtin::kWasmFloat64ToNumber);
|
|
OptimizedCompilationInfo info(base::ArrayVector("test"), &zone,
|
|
CodeKind::FOR_TESTING);
|
|
auto call_descriptor = Linkage::GetStubCallDescriptor(
|
|
&zone, callable.descriptor(), 0, CallDescriptor::kNoFlags,
|
|
Operator::kNoProperties);
|
|
CHECK(call_descriptor);
|
|
CHECK_EQ(0, static_cast<int>(call_descriptor->ParameterSlotCount()));
|
|
CHECK_EQ(1, static_cast<int>(call_descriptor->ParameterCount()));
|
|
CHECK_EQ(1, static_cast<int>(call_descriptor->ReturnCount()));
|
|
CHECK_EQ(Operator::kNoProperties, call_descriptor->properties());
|
|
CHECK_EQ(false, call_descriptor->IsJSFunctionCall());
|
|
|
|
CHECK_EQ(call_descriptor->GetInputType(1), MachineType::Float64());
|
|
CHECK(call_descriptor->GetInputLocation(1).IsRegister());
|
|
CHECK_EQ(call_descriptor->GetReturnType(0), MachineType::AnyTagged());
|
|
CHECK(call_descriptor->GetReturnLocation(0).IsRegister());
|
|
CHECK_EQ(call_descriptor->GetReturnLocation(0).GetLocation(),
|
|
kReturnRegister0.code());
|
|
}
|
|
#endif // V8_ENABLE_WEBASSEMBLY
|
|
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|