2459046c1d
The "Address" type is V8's general-purpose type for manipulating memory addresses. Per the C++ spec, pointer arithmetic and pointer comparisons are undefined behavior except within the same array; since we generally don't operate within a C++ array, our general-purpose type shouldn't be a pointer type. Bug: v8:3770 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib96016c24a0f18bcdba916dabd83e3f24a1b5779 Reviewed-on: https://chromium-review.googlesource.com/988657 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52601}
92 lines
3.2 KiB
C++
92 lines
3.2 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/heap/factory.h"
|
|
#include "src/isolate.h"
|
|
#include "src/objects-inl.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
TEST(CodeLayoutWithoutUnwindingInfo) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
|
|
// "Hello, World!" in ASCII.
|
|
byte buffer_array[13] = {0x48, 0x65, 0x6C, 0x6C, 0x6F, 0x2C, 0x20,
|
|
0x57, 0x6F, 0x72, 0x6C, 0x64, 0x21};
|
|
|
|
byte* buffer = &buffer_array[0];
|
|
int buffer_size = sizeof(buffer_array);
|
|
|
|
CodeDesc code_desc;
|
|
code_desc.buffer = buffer;
|
|
code_desc.buffer_size = buffer_size;
|
|
code_desc.constant_pool_size = 0;
|
|
code_desc.instr_size = buffer_size;
|
|
code_desc.reloc_size = 0;
|
|
code_desc.origin = nullptr;
|
|
code_desc.unwinding_info = nullptr;
|
|
code_desc.unwinding_info_size = 0;
|
|
|
|
Handle<Code> code = CcTest::i_isolate()->factory()->NewCode(
|
|
code_desc, Code::STUB, Handle<Object>::null());
|
|
|
|
CHECK(!code->has_unwinding_info());
|
|
CHECK_EQ(code->raw_instruction_size(), buffer_size);
|
|
CHECK_EQ(0, memcmp(reinterpret_cast<void*>(code->raw_instruction_start()),
|
|
buffer, buffer_size));
|
|
CHECK_EQ(code->raw_instruction_end() - code->address(),
|
|
Code::kHeaderSize + buffer_size);
|
|
}
|
|
|
|
TEST(CodeLayoutWithUnwindingInfo) {
|
|
CcTest::InitializeVM();
|
|
HandleScope handle_scope(CcTest::i_isolate());
|
|
|
|
// "Hello, World!" in ASCII.
|
|
byte buffer_array[13] = {0x48, 0x65, 0x6C, 0x6C, 0x6F, 0x2C, 0x20,
|
|
0x57, 0x6F, 0x72, 0x6C, 0x64, 0x21};
|
|
|
|
// "JavaScript" in ASCII.
|
|
byte unwinding_info_array[10] = {0x4A, 0x61, 0x76, 0x61, 0x53,
|
|
0x63, 0x72, 0x69, 0x70, 0x74};
|
|
|
|
byte* buffer = &buffer_array[0];
|
|
int buffer_size = sizeof(buffer_array);
|
|
byte* unwinding_info = &unwinding_info_array[0];
|
|
int unwinding_info_size = sizeof(unwinding_info_array);
|
|
|
|
CodeDesc code_desc;
|
|
code_desc.buffer = buffer;
|
|
code_desc.buffer_size = buffer_size;
|
|
code_desc.constant_pool_size = 0;
|
|
code_desc.instr_size = buffer_size;
|
|
code_desc.reloc_size = 0;
|
|
code_desc.origin = nullptr;
|
|
code_desc.unwinding_info = unwinding_info;
|
|
code_desc.unwinding_info_size = unwinding_info_size;
|
|
|
|
Handle<Code> code = CcTest::i_isolate()->factory()->NewCode(
|
|
code_desc, Code::STUB, Handle<Object>::null());
|
|
|
|
CHECK(code->has_unwinding_info());
|
|
CHECK_EQ(code->raw_instruction_size(), buffer_size);
|
|
CHECK_EQ(0, memcmp(reinterpret_cast<void*>(code->raw_instruction_start()),
|
|
buffer, buffer_size));
|
|
CHECK(IsAligned(code->GetUnwindingInfoSizeOffset(), 8));
|
|
CHECK_EQ(code->unwinding_info_size(), unwinding_info_size);
|
|
CHECK(IsAligned(code->unwinding_info_start(), 8));
|
|
CHECK_EQ(memcmp(reinterpret_cast<void*>(code->unwinding_info_start()),
|
|
unwinding_info, unwinding_info_size),
|
|
0);
|
|
CHECK_EQ(code->unwinding_info_end() - code->address(),
|
|
Code::kHeaderSize + RoundUp(buffer_size, kInt64Size) + kInt64Size +
|
|
unwinding_info_size);
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|