6ea78398aa
The infrastructure runs everything already in Python3, so this is mostly a clean-up. For MB, a python2 holdover was removed and new lint errors were fixed. The renames were automated with: git grep -e "/usr/bin/python$" | cut -d':' -f1 | xargs sed -i 's/#!\/usr\/bin\/python$/#!\/usr\/bin\/python3/1' and git grep -e "/usr/bin/env python$" | cut -d':' -f1 | xargs sed -i 's/#!\/usr\/bin\/env python$/#!\/usr\/bin\/env python3/1' Bug: v8:13148 Change-Id: If4f3c7635e72fa134798d55314ac1aa92ddd01bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3811499 Reviewed-by: Liviu Rau <liviurau@google.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82231}
47 lines
1.7 KiB
Python
47 lines
1.7 KiB
Python
# Copyright 2016 the V8 project authors. All rights reserved.
|
|
# Copyright 2015 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
# This line is 'magic' in that git-cl looks for it to decide whether to
|
|
# use Python3 instead of Python2 when running the code in this file.
|
|
USE_PYTHON3 = True
|
|
|
|
|
|
def _CommonChecks(input_api, output_api):
|
|
results = []
|
|
|
|
# Run Pylint over the files in the directory.
|
|
pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api)
|
|
results.extend(input_api.RunTests(pylint_checks))
|
|
|
|
# Run the MB unittests.
|
|
results.extend(
|
|
input_api.canned_checks.RunUnitTestsInDirectory(input_api, output_api,
|
|
'.', [r'^.+_test\.py$'],
|
|
run_on_python2=False))
|
|
|
|
# Validate the format of the mb_config.pyl file.
|
|
cmd = [input_api.python3_executable, 'mb.py', 'validate']
|
|
kwargs = {'cwd': input_api.PresubmitLocalPath()}
|
|
results.extend(input_api.RunTests([
|
|
input_api.Command(name='mb_validate',
|
|
cmd=cmd, kwargs=kwargs,
|
|
message=output_api.PresubmitError,
|
|
python3=True)]))
|
|
|
|
is_mb_config = (lambda filepath: 'mb_config.pyl' in filepath.LocalPath())
|
|
results.extend(
|
|
input_api.canned_checks.CheckLongLines(
|
|
input_api, output_api, maxlen=80, source_file_filter=is_mb_config))
|
|
|
|
return results
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return _CommonChecks(input_api, output_api)
|