98300313b3
This CL applies the following changes: - JSCallReducer no longer generates a CheckBigInt in front of the generated BigIntAsUintN. - This results in a slight change of the semantics of the latter, which now includes the necessary type check. Typer and Verifier are changed accordingly. - The BigIntAsUintN operator is now effectful, since it can now deopt. - IrOpcode::kBigIntAsUintN is now lowered in SimplifedLowering instead of EffectControlLinearizer, the necessary type check is introduced by the RepresentationChanger. - Adds a small mjsunit test to check the correct deoptimization behavior of optimized BigInt.asUintN. ==> Remove UseInfo::TruncatingWord64()! Drive-by: Fix an issue in ChangeUnaryToPureBinaryOp when the new_input is at index 1. Drive-by: Introduce an %Is64Bit() intrinsic to allow tests to distinguish 32 and 64 bit architectures. Bug: v8:11682 Change-Id: I448f892d3bd2280d731ae5b248c833de8faf1bd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2843816 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#74147}
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --opt --no-always-opt
|
|
|
|
|
|
function f(x) {
|
|
return BigInt.asUintN(3, x);
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(f);
|
|
assertEquals(7n, f(7n));
|
|
assertEquals(1n, f(9n));
|
|
%OptimizeFunctionOnNextCall(f);
|
|
assertEquals(7n, f(7n));
|
|
assertEquals(1n, f(9n));
|
|
assertOptimized(f);
|
|
|
|
// BigInt.asUintN throws TypeError for non-BigInt arguments.
|
|
assertThrows(() => f(2), TypeError);
|
|
if(%Is64Bit()) {
|
|
// On 64 bit architectures TurboFan optimizes BigInt.asUintN to native code
|
|
// that deoptimizes on non-BigInt arguments.
|
|
assertUnoptimized(f);
|
|
|
|
// The next time the function is optimized, speculation should be disabled
|
|
// so the builtin call is kept, which won't deoptimize again.
|
|
%PrepareFunctionForOptimization(f);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
}
|
|
assertEquals(7n, f(7n));
|
|
assertOptimized(f);
|
|
|
|
// Re-optimized still throws but does not deopt-loop.
|
|
assertThrows(() => f(2), TypeError);
|
|
assertOptimized(f);
|