22ff09e06a
If an inner function only declares a variable but doesn't use it, Parser and PreParser produced different unresolved variables, and that confused the pessimistic context allocation. BUG=chromium:650969 Review-Url: https://codereview.chromium.org/2388183003 Cr-Commit-Position: refs/heads/master@{#39947}
363 lines
6.2 KiB
JavaScript
363 lines
6.2 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --min-preparse-length 1 --allow-natives-syntax
|
|
|
|
// Test that the information on which variables to allocate in context doesn't
|
|
// change when recompiling.
|
|
|
|
(function TestVarInInnerFunction() {
|
|
// Introduce variables which would potentially be context allocated, depending
|
|
// on whether an inner function refers to them or not.
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
var a; // This will make "a" actually not be context allocated.
|
|
a; b; c;
|
|
}
|
|
// Force recompilation.
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
|
|
// Other tests are the same, except that the shadowing variable "a" in inner
|
|
// functions is declared differently.
|
|
|
|
(function TestLetInInnerFunction() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
let a;
|
|
a; b; c;
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionParameter() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner(a) {
|
|
a; b; c;
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerInnerFunctionParameter() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
function innerinner(a) { a; b; c; }
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerArrowFunctionParameter() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
var f = a => a + b + c;
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionInnerFunction() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
function a() { }
|
|
a; b; c;
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionSloppyBlockFunction() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
if (true) { function a() { } }
|
|
a; b; c;
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionCatchVariable() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
try {
|
|
}
|
|
catch(a) {
|
|
a; b; c;
|
|
}
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionLoopVariable1() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
for (var a in {}) {
|
|
a; b; c;
|
|
}
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionLoopVariable2() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
for (let a in {}) {
|
|
a; b; c;
|
|
}
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionLoopVariable3() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
for (var a of []) {
|
|
a; b; c;
|
|
}
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionLoopVariable4() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
for (let a of []) {
|
|
a; b; c;
|
|
}
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
(function TestInnerFunctionClass() {
|
|
var a = 1;
|
|
var b = 2;
|
|
var c = 3;
|
|
function inner() {
|
|
class a {}
|
|
a; b; c;
|
|
}
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
assertEquals(1, a);
|
|
assertEquals(2, b);
|
|
assertEquals(3, c);
|
|
}
|
|
})();
|
|
|
|
// A cluster of similar tests where the inner function only declares a variable
|
|
// whose name clashes with an outer function variable name, but doesn't use it.
|
|
(function TestRegress650969_1() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner() {
|
|
var a;
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function TestRegress650969_2() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner() {
|
|
var a = 6;
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function TestRegress650969_3() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner() {
|
|
var a, b;
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function TestRegress650969_4() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner() {
|
|
var a = 6, b;
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function TestRegress650969_5() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner() {
|
|
let a;
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function TestRegress650969_6() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner() {
|
|
let a = 6;
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function TestRegress650969_7() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner() {
|
|
let a, b;
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function TestRegress650969_8() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner() {
|
|
let a = 6, b;
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function TestRegress650969_9() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
if (i == 1) {
|
|
%OptimizeOsr();
|
|
}
|
|
var a;
|
|
function inner(a) {
|
|
}
|
|
}
|
|
})();
|