a4252db322
Recompute the spill offsets for values in the merge region, instead of reusing the offsets of the source. This ensures that spill slots stay contiguous (modulo alignment). This also solves a correctness issue where the spill offsets in the merge region could move up, thereby overwriting the source of another move. With this change, the spill offsets always move down (to fill the gap) or stay the same, such that processing them from bottom to top can only overwrite sources of already-processed moves. Since we do not reuse the current state's offsets, this might generate extra stack moves and regress generated code performance a bit. Drive-by: print spill offsets in the Liftoff trace R=clemensb@chromium.org Bug: v8:12270 Change-Id: I8d20df8fc1e80dd36b6f651de457686e9935a628 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3245115 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77556}
40 lines
1.6 KiB
JavaScript
40 lines
1.6 KiB
JavaScript
// Copyright 2021 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --liftoff-only
|
|
|
|
d8.file.execute("test/mjsunit/wasm/wasm-module-builder.js");
|
|
|
|
(function Regress12270() {
|
|
print(arguments.callee.name);
|
|
let builder = new WasmModuleBuilder();
|
|
let sig = makeSig([], [kWasmF32, kWasmF64, kWasmF64, kWasmF64, kWasmF64, kWasmF64, kWasmF64, kWasmF64, kWasmF64, kWasmF64, kWasmF64]);
|
|
let sig_index = builder.addType(sig);
|
|
builder.addFunction("main", sig).addBody([
|
|
kExprI32Const, 0,
|
|
kExprIf, sig_index,
|
|
kExprF32Const, 0x0, 0x0, 0x0, 0x0,
|
|
kExprBlock, kWasmVoid,
|
|
kExprCallFunction, 0,
|
|
kExprBr, 1,
|
|
kExprEnd,
|
|
kExprUnreachable,
|
|
kExprElse,
|
|
kExprF32Const, 0x00, 0x00, 0x80, 0x3f, // 1.0
|
|
kExprF64Const, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xf0, 0x3f, // 1.0
|
|
kExprF64Const, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x40, // 2.0
|
|
kExprF64Const, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
kExprF64Const, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
kExprF64Const, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
kExprF64Const, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
kExprF64Const, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
kExprF64Const, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
kExprF64Const, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
kExprF64Const, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
|
|
kExprEnd
|
|
]).exportFunc();
|
|
let instance = builder.instantiate();
|
|
assertEquals(1.0, instance.exports.main()[1]);
|
|
})();
|