ab6462e883
fixed Abort() calling sequence on platforms with function descriptors by taking function descriptor of the External Reference object into account when calling C code. Change-Id: I54c04a5f1774f2768380cc5c95b1b807204335ce Reviewed-on: https://chromium-review.googlesource.com/c/1258186 Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56356}
75 lines
2.2 KiB
C++
75 lines
2.2 KiB
C++
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/macro-assembler.h"
|
|
#include "src/ppc/assembler-ppc-inl.h"
|
|
#include "src/simulator.h"
|
|
#include "test/common/assembler-tester.h"
|
|
#include "test/unittests/test-utils.h"
|
|
#include "testing/gtest-support.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
#define __ tasm.
|
|
|
|
// Test the ppc assembler by compiling some simple functions into
|
|
// a buffer and executing them. These tests do not initialize the
|
|
// V8 library, create a context, or use any V8 objects.
|
|
|
|
class TurboAssemblerTest : public TestWithIsolate {};
|
|
|
|
TEST_F(TurboAssemblerTest, TestHardAbort) {
|
|
size_t allocated;
|
|
byte* buffer = AllocateAssemblerBuffer(&allocated);
|
|
TurboAssembler tasm(nullptr, AssemblerOptions{}, buffer,
|
|
static_cast<int>(allocated), CodeObjectRequired::kNo);
|
|
// Called from C
|
|
__ function_descriptor();
|
|
|
|
__ set_abort_hard(true);
|
|
|
|
__ Abort(AbortReason::kNoReason);
|
|
|
|
CodeDesc desc;
|
|
tasm.GetCode(nullptr, &desc);
|
|
MakeAssemblerBufferExecutable(buffer, allocated);
|
|
// We need an isolate here to execute in the simulator.
|
|
auto f = GeneratedCode<void>::FromBuffer(isolate(), buffer);
|
|
|
|
ASSERT_DEATH_IF_SUPPORTED({ f.Call(); }, "abort: no reason");
|
|
}
|
|
|
|
TEST_F(TurboAssemblerTest, TestCheck) {
|
|
size_t allocated;
|
|
byte* buffer = AllocateAssemblerBuffer(&allocated);
|
|
TurboAssembler tasm(nullptr, AssemblerOptions{}, buffer,
|
|
static_cast<int>(allocated), CodeObjectRequired::kNo);
|
|
// Called from C
|
|
__ function_descriptor();
|
|
|
|
__ set_abort_hard(true);
|
|
|
|
// Fail if the first parameter is 17.
|
|
__ mov(r4, Operand(17));
|
|
__ cmp(r3, r4); // 1st parameter is in {r3}.
|
|
__ Check(Condition::ne, AbortReason::kNoReason);
|
|
__ Ret();
|
|
|
|
CodeDesc desc;
|
|
tasm.GetCode(nullptr, &desc);
|
|
MakeAssemblerBufferExecutable(buffer, allocated);
|
|
// We need an isolate here to execute in the simulator.
|
|
auto f = GeneratedCode<void, int>::FromBuffer(isolate(), buffer);
|
|
|
|
f.Call(0);
|
|
f.Call(18);
|
|
ASSERT_DEATH_IF_SUPPORTED({ f.Call(17); }, "abort: no reason");
|
|
}
|
|
|
|
#undef __
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|