0f90341552
... instead of manually calculating index of the Context parameter. Drive-by: follow correct parameter count pattern: * CodeAssemblerTester with JS calling convention and fixed parameter count expects that the count includes the receiver parameter. * FunctionTester's parameter count doesn't include receiver. * Use JSParameterCount(kNumParams) instead of (kNumParams+1) and "Include receiver" comment. Bug: v8:13312, v8:11112 Change-Id: I2cd25f596882e0bdf6b6254a0182a391ad7b73b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4034174 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#84352}
88 lines
2.9 KiB
C++
88 lines
2.9 KiB
C++
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_TEST_COMMON_CODE_ASSEMBLER_TESTER_H_
|
|
#define V8_TEST_COMMON_CODE_ASSEMBLER_TESTER_H_
|
|
|
|
#include "src/codegen/assembler.h"
|
|
#include "src/codegen/interface-descriptors.h"
|
|
#include "src/compiler/code-assembler.h"
|
|
#include "src/compiler/raw-machine-assembler.h"
|
|
#include "src/execution/isolate.h"
|
|
#include "src/handles/handles.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
class CodeAssemblerTester {
|
|
public:
|
|
CodeAssemblerTester(Isolate* isolate,
|
|
const CallInterfaceDescriptor& descriptor,
|
|
const char* name = "test")
|
|
: zone_(isolate->allocator(), ZONE_NAME, kCompressGraphZone),
|
|
scope_(isolate),
|
|
state_(isolate, &zone_, descriptor, CodeKind::FOR_TESTING, name,
|
|
Builtin::kNoBuiltinId) {}
|
|
|
|
// Test generating code for a stub. Assumes VoidDescriptor call interface.
|
|
explicit CodeAssemblerTester(Isolate* isolate, const char* name = "test")
|
|
: CodeAssemblerTester(isolate, VoidDescriptor{}, name) {}
|
|
|
|
// Test generating code for a JS function (e.g. builtins).
|
|
CodeAssemblerTester(Isolate* isolate, int parameter_count,
|
|
CodeKind kind = CodeKind::BUILTIN,
|
|
const char* name = "test")
|
|
: zone_(isolate->allocator(), ZONE_NAME, kCompressGraphZone),
|
|
scope_(isolate),
|
|
state_(isolate, &zone_, parameter_count, kind, name) {
|
|
// Parameter count must include at least the receiver.
|
|
DCHECK_LE(1, parameter_count);
|
|
}
|
|
|
|
CodeAssemblerTester(Isolate* isolate, CodeKind kind,
|
|
const char* name = "test")
|
|
: CodeAssemblerTester(isolate, 1, kind, name) {}
|
|
|
|
CodeAssemblerTester(Isolate* isolate, CallDescriptor* call_descriptor,
|
|
const char* name = "test")
|
|
: zone_(isolate->allocator(), ZONE_NAME, kCompressGraphZone),
|
|
scope_(isolate),
|
|
state_(isolate, &zone_, call_descriptor, CodeKind::FOR_TESTING, name,
|
|
Builtin::kNoBuiltinId) {}
|
|
|
|
CodeAssemblerState* state() { return &state_; }
|
|
|
|
// Direct low-level access to the machine assembler, for testing only.
|
|
RawMachineAssembler* raw_assembler_for_testing() {
|
|
return state_.raw_assembler_.get();
|
|
}
|
|
|
|
Handle<Code> GenerateCode() {
|
|
return GenerateCode(AssemblerOptions::Default(scope_.isolate()));
|
|
}
|
|
|
|
Handle<Code> GenerateCode(const AssemblerOptions& options) {
|
|
if (state_.InsideBlock()) {
|
|
CodeAssembler(&state_).Unreachable();
|
|
}
|
|
return CodeAssembler::GenerateCode(&state_, options, nullptr);
|
|
}
|
|
|
|
Handle<Code> GenerateCodeCloseAndEscape() {
|
|
return scope_.CloseAndEscape(GenerateCode());
|
|
}
|
|
|
|
private:
|
|
Zone zone_;
|
|
HandleScope scope_;
|
|
CodeAssemblerState state_;
|
|
};
|
|
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_TEST_COMMON_CODE_ASSEMBLER_TESTER_H_
|